From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Christian Daudt <csd@broadcom.com>
Cc: csd_b@daudt.org, Stephen Warren <swarren@nvidia.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-doc@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devicetree-discuss@lists.ozlabs.org, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org,
Rob Herring <rob.herring@calxeda.com>,
Grant Likely <grant.likely@secretlab.ca>,
Wei WANG <wei_wang@realsil.com.cn>,
Ludovic Desroches <ludovic.desroches@atmel.com>,
"Mike A. Chan" <mikechan@google.com>,
Rob Landley <rob@landley.net>, Olof Johansson <olof@lixom.net>,
Russell King <linux@arm.linux.org.uk>,
Chris Ball <cjb@laptop.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: mmc: bcm281xx SDHCI driver
Date: Fri, 10 May 2013 16:37:01 +0200 [thread overview]
Message-ID: <20130510143701.GC22508@game.jcrosoft.org> (raw)
In-Reply-To: <518CA1DF.5050008@broadcom.com>
On 00:29 Fri 10 May , Christian Daudt wrote:
> Thanks for the feedback.
>
> On 13-05-08 11:35 PM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> >On 22:55 Wed 08 May , Christian Daudt wrote:
> >>Add SDHCI driver for the Broadcom 281xx SoCs. Also
> >>add bindings for it into bcm281xx dts files.
> >>Still missing:
> >> - power managemement
> >split the dts/dtsi in an other patch
> ok.
> >>Signed-off-by: Christian Daudt <csd@broadcom.com>
> >>
> >>diff --git a/arch/arm/configs/bcm_defconfig b/arch/arm/configs/bcm_defconfig
> >>index e3bf2d6..65edf6d 100644
> >>--- a/arch/arm/configs/bcm_defconfig
> >>+++ b/arch/arm/configs/bcm_defconfig
> >>@@ -78,6 +78,13 @@ CONFIG_BACKLIGHT_LCD_SUPPORT=y
> >> CONFIG_LCD_CLASS_DEVICE=y
> >> CONFIG_BACKLIGHT_CLASS_DEVICE=y
> >> # CONFIG_USB_SUPPORT is not set
> >>+CONFIG_MMC=y
> >>+CONFIG_MMC_UNSAFE_RESUME=y
> >>+CONFIG_MMC_BLOCK_MINORS=32
> >>+CONFIG_MMC_TEST=y
> >>+CONFIG_MMC_SDHCI=y
> >>+CONFIG_MMC_SDHCI_PLTFM=y
> >>+CONFIG_MMC_SDHCI_BCM_KONA=y
> >> CONFIG_NEW_LEDS=y
> >> CONFIG_LEDS_CLASS=y
> >> CONFIG_LEDS_TRIGGERS=y
> >>diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> >>index d88219e..e067c5a 100644
> >>--- a/drivers/mmc/host/Kconfig
> >>+++ b/drivers/mmc/host/Kconfig
> >>@@ -238,6 +238,16 @@ config MMC_SDHCI_S3C_DMA
> >> YMMV.
> >>+config MMC_SDHCI_BCM_KONA
> >>+ tristate "SDHCI support on Broadcom KONA platform"
> >>+ depends on ARCH_BCM && MMC_SDHCI_PLTFM
> >select MMC_SDHCI_PLTFM
> >will be better
> Ok - changed it. Why is the select is better than the depends ?
so you do not need to enable MMC_SDHCI_PLTFM
and you can drop one line in the savdefconfig
if tomorrow you need regulator select it so a old defconfig will continue to
work
Best Regards,
J.
next prev parent reply other threads:[~2013-05-10 14:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-09 5:55 [PATCH] ARM: mmc: bcm281xx SDHCI driver Christian Daudt
2013-05-09 6:35 ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-10 7:23 ` Christian Daudt
2013-05-10 7:29 ` Christian Daudt
2013-05-10 10:26 ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-10 14:37 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2013-05-10 7:45 ` Christian Daudt
2013-05-11 4:28 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130510143701.GC22508@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=arnd@arndb.de \
--cc=cjb@laptop.org \
--cc=csd@broadcom.com \
--cc=csd_b@daudt.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=ludovic.desroches@atmel.com \
--cc=mikechan@google.com \
--cc=olof@lixom.net \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=swarren@nvidia.com \
--cc=wei_wang@realsil.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).