From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lorenzo Pieralisi Subject: Re: [RFC PATCH v3] drivers: bus: add ARM CCI support Date: Wed, 15 May 2013 15:24:42 +0100 Message-ID: <20130515142441.GA385@e102568-lin.cambridge.arm.com> References: <1368095640-3675-1-git-send-email-lorenzo.pieralisi@arm.com> <1368095640-3675-2-git-send-email-lorenzo.pieralisi@arm.com> <20130514130005.GD29592@e102654-lin.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Nicolas Pitre Cc: Jon Medhurst , Javi Merino , Russell King , "devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org" , Stephen Boyd , "rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org" , "grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" , Santosh Shilimkar , Amit Kucheria , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: devicetree@vger.kernel.org On Tue, May 14, 2013 at 11:21:32PM +0100, Nicolas Pitre wrote: > On Tue, 14 May 2013, Javi Merino wrote: > > > On Thu, May 09, 2013 at 11:34:00AM +0100, Lorenzo Pieralisi wrote: > > > > > +static inline void init_cpu_port(struct cpu_port *port, u32 index, u32 mpidr) > > > > The mpidr should be u64. > > Why? Since on arm64 MPIDR_EL1 size is 64 bits, we need the driver to work on both arm and arm64. Lorenzo