From: David Miller <davem@davemloft.net>
To: mugunthanvnm@ti.com
Cc: netdev@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
linux-omap@vger.kernel.org, benoit.cousson@linaro.orgm,
paul@pwsan.com, gururaja.hebbar@ti.com
Subject: Re: [net-next resend PATCH 1/6] net: cpsw: enhance pinctrl support
Date: Wed, 22 May 2013 23:57:41 -0700 (PDT) [thread overview]
Message-ID: <20130522.235741.135665074490271750.davem@davemloft.net> (raw)
In-Reply-To: <1369130103-743-2-git-send-email-mugunthanvnm@ti.com>
From: Mugunthan V N <mugunthanvnm@ti.com>
Date: Tue, 21 May 2013 15:24:58 +0530
> + priv->pins_default = pinctrl_lookup_state(priv->pinctrl,
> + PINCTRL_STATE_DEFAULT);
This is not indented correctly.
Argument on the second, and subsequent, lines of a function call
must start at the first column after the openning parenthesis of
the function call itself.
Please audit for this problem in your entire patch series, fix
it up, and resubmit the full set of patches.
Thanks.
next prev parent reply other threads:[~2013-05-23 6:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-21 9:54 [net-next resend PATCH 0/6] Adding pinctrl PM support for CPSW and MDIO Mugunthan V N
2013-05-21 9:54 ` [net-next resend PATCH 1/6] net: cpsw: enhance pinctrl support Mugunthan V N
2013-05-23 6:57 ` David Miller [this message]
2013-05-23 9:14 ` Mugunthan V N
2013-05-23 11:28 ` Hebbar, Gururaja
2013-05-23 19:10 ` David Miller
2013-05-21 9:54 ` [net-next resend PATCH 2/6] net: davinci_mdio: " Mugunthan V N
2013-05-21 9:55 ` [net-next resend PATCH 3/6] ARM: dts: AM33XX: Add pinmux configuration for CPSW to beaglebone Mugunthan V N
2013-05-21 9:55 ` [net-next resend PATCH 4/6] ARM: dts: AM33XX: Add CPSW phy_id device tree data to am335x-evmsk Mugunthan V N
2013-05-21 9:55 ` [net-next resend PATCH 5/6] ARM: dts: AM33XX: Add pinmux configuration for CPSW to EVMsk Mugunthan V N
2013-05-21 9:55 ` [net-next resend PATCH 6/6] ARM: dts: AM33XX: Add pinmux configuration for CPSW to am335x EVM Mugunthan V N
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130522.235741.135665074490271750.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=benoit.cousson@linaro.orgm \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=gururaja.hebbar@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).