From: Mark Brown <broonie@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Grant Likely <grant.likely@linaro.org>,
alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <rob.herring@calxeda.com>,
devicetree-discuss@lists.ozlabs.org
Subject: Re: [PATCH] ASoC: Add ssm2518 support
Date: Wed, 22 May 2013 17:07:56 -0500 [thread overview]
Message-ID: <20130522220756.GF1627@sirena.org.uk> (raw)
In-Reply-To: <519D0B84.70307@metafoo.de>
[-- Attachment #1.1: Type: text/plain, Size: 631 bytes --]
On Wed, May 22, 2013 at 08:16:36PM +0200, Lars-Peter Clausen wrote:
> On 05/22/2013 07:57 PM, Mark Brown wrote:
> >> + if (slots == 0) {
> >> + return regmap_update_bits(ssm2518->regmap,
> >> + SSM2518_REG_SAI_CTRL1, SSM2518_SAI_CTRL1_SAI_MASK,
> >> + SSM2518_SAI_CTRL1_SAI_I2S);
> >> + }
> > You've got quite a few single statement if () blocks with { } which
> > shouldn't be there.
> >
> I prefer to only do this for single single-line statements.
That's not the kernel coding style and I have to say these examples were
all jumping out at me as weird, I was looking for an else clause or
something.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
prev parent reply other threads:[~2013-05-22 22:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-22 17:00 [PATCH] ASoC: Add ssm2518 support Lars-Peter Clausen
2013-05-22 17:57 ` Mark Brown
2013-05-22 18:16 ` Lars-Peter Clausen
2013-05-22 22:07 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130522220756.GF1627@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@linaro.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=rob.herring@calxeda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox