* [PATCH] ARM: ux500: enable the crypto and hash on all dbx500 @ 2013-05-24 6:48 Linus Walleij [not found] ` <1369378122-25897-1-git-send-email-linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org> 0 siblings, 1 reply; 4+ messages in thread From: Linus Walleij @ 2013-05-24 6:48 UTC (permalink / raw) To: linux-arm-kernel Cc: devicetree-discuss, Gabriel Fernandez, Lee Jones, Linus Walleij From: Linus Walleij <linus.walleij@linaro.org> Commits: "ARM: ux500: Add Device Tree nodes for the ux500 Crypt device" "ARM: ux500: Add Device Tree nodes for the ux500 Hash device" Added the crypto and hash devices conditionally, i.e. so as to be turned on per-board by setting an "status" property on the device from "disabled" to "okay" on each device. This is wrong since this is an SoC feature, it is not board dependent. It is the same ASIC under all circumstances and functionality does not vary with board family. This moves the enablement into the SoC file. Cc: Lee Jones <lee.jones@linaro.org> Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- arch/arm/boot/dts/dbx5x0.dtsi | 4 ---- arch/arm/boot/dts/snowball.dts | 8 -------- 2 files changed, 12 deletions(-) diff --git a/arch/arm/boot/dts/dbx5x0.dtsi b/arch/arm/boot/dts/dbx5x0.dtsi index f051963..cd5cd09 100644 --- a/arch/arm/boot/dts/dbx5x0.dtsi +++ b/arch/arm/boot/dts/dbx5x0.dtsi @@ -760,17 +760,13 @@ compatible = "stericsson,ux500-cryp"; reg = <0xa03cb000 0x1000>; interrupts = <0 15 0x4>; - v-ape-supply = <&db8500_vape_reg>; - status = "disabled"; }; hash@a03c2000 { compatible = "stericsson,ux500-hash"; reg = <0xa03c2000 0x1000>; - v-ape-supply = <&db8500_vape_reg>; - status = "disabled"; }; }; }; diff --git a/arch/arm/boot/dts/snowball.dts b/arch/arm/boot/dts/snowball.dts index bda002f..e8219cc7 100644 --- a/arch/arm/boot/dts/snowball.dts +++ b/arch/arm/boot/dts/snowball.dts @@ -356,13 +356,5 @@ }; }; }; - - cryp@a03cb000 { - status = "okay"; - }; - - hash@a03c2000 { - status = "okay"; - }; }; }; -- 1.7.11.3 ^ permalink raw reply related [flat|nested] 4+ messages in thread
[parent not found: <1369378122-25897-1-git-send-email-linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>]
* Re: [PATCH] ARM: ux500: enable the crypto and hash on all dbx500 [not found] ` <1369378122-25897-1-git-send-email-linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org> @ 2013-05-24 8:27 ` Lee Jones [not found] ` <20130524082758.GP22683-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 0 siblings, 1 reply; 4+ messages in thread From: Lee Jones @ 2013-05-24 8:27 UTC (permalink / raw) To: Linus Walleij Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ, Gabriel Fernandez, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r On Fri, 24 May 2013, Linus Walleij wrote: > From: Linus Walleij <linus.walleij@linaro.org> > > Commits: > "ARM: ux500: Add Device Tree nodes for the ux500 Crypt device" > "ARM: ux500: Add Device Tree nodes for the ux500 Hash device" > > Added the crypto and hash devices conditionally, i.e. so as to > be turned on per-board by setting an "status" property on the > device from "disabled" to "okay" on each device. > > This is wrong since this is an SoC feature, it is not board > dependent. It is the same ASIC under all circumstances and > functionality does not vary with board family. > > This moves the enablement into the SoC file. > > Cc: Lee Jones <lee.jones@linaro.org> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > --- > arch/arm/boot/dts/dbx5x0.dtsi | 4 ---- > arch/arm/boot/dts/snowball.dts | 8 -------- > 2 files changed, 12 deletions(-) > > diff --git a/arch/arm/boot/dts/dbx5x0.dtsi b/arch/arm/boot/dts/dbx5x0.dtsi > index f051963..cd5cd09 100644 > --- a/arch/arm/boot/dts/dbx5x0.dtsi > +++ b/arch/arm/boot/dts/dbx5x0.dtsi > @@ -760,17 +760,13 @@ > compatible = "stericsson,ux500-cryp"; > reg = <0xa03cb000 0x1000>; > interrupts = <0 15 0x4>; > - Why do you insist on removing all line spacings from the DTS file? I saw you removing them in between nodes too. > v-ape-supply = <&db8500_vape_reg>; > - status = "disabled"; > }; > > hash@a03c2000 { > compatible = "stericsson,ux500-hash"; > reg = <0xa03c2000 0x1000>; > - > v-ape-supply = <&db8500_vape_reg>; > - status = "disabled"; > }; > }; > }; > diff --git a/arch/arm/boot/dts/snowball.dts b/arch/arm/boot/dts/snowball.dts > index bda002f..e8219cc7 100644 > --- a/arch/arm/boot/dts/snowball.dts > +++ b/arch/arm/boot/dts/snowball.dts > @@ -356,13 +356,5 @@ > }; > }; > }; > - > - cryp@a03cb000 { > - status = "okay"; > - }; > - > - hash@a03c2000 { > - status = "okay"; > - }; > }; > }; -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog _______________________________________________ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <20130524082758.GP22683-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH] ARM: ux500: enable the crypto and hash on all dbx500 [not found] ` <20130524082758.GP22683-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> @ 2013-05-24 11:13 ` Linus Walleij [not found] ` <CACRpkdb1CZKoaG6nNF-yBC3Eovoe3_0BHa6uO-OQkePDcrkamg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 0 siblings, 1 reply; 4+ messages in thread From: Linus Walleij @ 2013-05-24 11:13 UTC (permalink / raw) To: Lee Jones Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Gabriel Fernandez, Linus Walleij, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org On Fri, May 24, 2013 at 10:27 AM, Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote: > On Fri, 24 May 2013, Linus Walleij wrote: >> From: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> >> >> Commits: >> "ARM: ux500: Add Device Tree nodes for the ux500 Crypt device" >> "ARM: ux500: Add Device Tree nodes for the ux500 Hash device" >> >> Added the crypto and hash devices conditionally, i.e. so as to >> be turned on per-board by setting an "status" property on the >> device from "disabled" to "okay" on each device. >> >> This is wrong since this is an SoC feature, it is not board >> dependent. It is the same ASIC under all circumstances and >> functionality does not vary with board family. >> >> This moves the enablement into the SoC file. >> >> Cc: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> >> Signed-off-by: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> >> --- >> arch/arm/boot/dts/dbx5x0.dtsi | 4 ---- >> arch/arm/boot/dts/snowball.dts | 8 -------- >> 2 files changed, 12 deletions(-) >> >> diff --git a/arch/arm/boot/dts/dbx5x0.dtsi b/arch/arm/boot/dts/dbx5x0.dtsi >> index f051963..cd5cd09 100644 >> --- a/arch/arm/boot/dts/dbx5x0.dtsi >> +++ b/arch/arm/boot/dts/dbx5x0.dtsi >> @@ -760,17 +760,13 @@ >> compatible = "stericsson,ux500-cryp"; >> reg = <0xa03cb000 0x1000>; >> interrupts = <0 15 0x4>; >> - > > Why do you insist on removing all line spacings from the DTS file? > > I saw you removing them in between nodes too. I was hit by a linespace when I was a child, since then I take every opportunity for revenge. If I keep the spacing, can I have your ACK? Yours, Linus Walleij ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <CACRpkdb1CZKoaG6nNF-yBC3Eovoe3_0BHa6uO-OQkePDcrkamg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH] ARM: ux500: enable the crypto and hash on all dbx500 [not found] ` <CACRpkdb1CZKoaG6nNF-yBC3Eovoe3_0BHa6uO-OQkePDcrkamg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2013-05-24 12:53 ` Lee Jones 0 siblings, 0 replies; 4+ messages in thread From: Lee Jones @ 2013-05-24 12:53 UTC (permalink / raw) To: Linus Walleij Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Gabriel Fernandez, Linus Walleij, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org On Fri, 24 May 2013, Linus Walleij wrote: > On Fri, May 24, 2013 at 10:27 AM, Lee Jones <lee.jones@linaro.org> wrote: > > On Fri, 24 May 2013, Linus Walleij wrote: > >> From: Linus Walleij <linus.walleij@linaro.org> > >> > >> Commits: > >> "ARM: ux500: Add Device Tree nodes for the ux500 Crypt device" > >> "ARM: ux500: Add Device Tree nodes for the ux500 Hash device" > >> > >> Added the crypto and hash devices conditionally, i.e. so as to > >> be turned on per-board by setting an "status" property on the > >> device from "disabled" to "okay" on each device. > >> > >> This is wrong since this is an SoC feature, it is not board > >> dependent. It is the same ASIC under all circumstances and > >> functionality does not vary with board family. > >> > >> This moves the enablement into the SoC file. > >> > >> Cc: Lee Jones <lee.jones@linaro.org> > >> Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > >> --- > >> arch/arm/boot/dts/dbx5x0.dtsi | 4 ---- > >> arch/arm/boot/dts/snowball.dts | 8 -------- > >> 2 files changed, 12 deletions(-) > >> > >> diff --git a/arch/arm/boot/dts/dbx5x0.dtsi b/arch/arm/boot/dts/dbx5x0.dtsi > >> index f051963..cd5cd09 100644 > >> --- a/arch/arm/boot/dts/dbx5x0.dtsi > >> +++ b/arch/arm/boot/dts/dbx5x0.dtsi > >> @@ -760,17 +760,13 @@ > >> compatible = "stericsson,ux500-cryp"; > >> reg = <0xa03cb000 0x1000>; > >> interrupts = <0 15 0x4>; > >> - > > > > Why do you insist on removing all line spacings from the DTS file? > > > > I saw you removing them in between nodes too. > > I was hit by a linespace when I was a child, since then I take > every opportunity for revenge. :) > If I keep the spacing, can I have your ACK? You can. For reference, I like a space separating all nodes too. :) -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog _______________________________________________ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-05-24 12:53 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-05-24 6:48 [PATCH] ARM: ux500: enable the crypto and hash on all dbx500 Linus Walleij [not found] ` <1369378122-25897-1-git-send-email-linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org> 2013-05-24 8:27 ` Lee Jones [not found] ` <20130524082758.GP22683-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2013-05-24 11:13 ` Linus Walleij [not found] ` <CACRpkdb1CZKoaG6nNF-yBC3Eovoe3_0BHa6uO-OQkePDcrkamg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2013-05-24 12:53 ` Lee Jones
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).