From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH 1/5] i2c: sunxi: Add Allwinner A1X i2c driver Date: Sat, 25 May 2013 17:22:31 +0200 Message-ID: <20130525152231.GF17847@lukather> References: <1367572669-24354-1-git-send-email-maxime.ripard@free-electrons.com> <1367572669-24354-2-git-send-email-maxime.ripard@free-electrons.com> <2868419.vHvm2rOVdd@flatron> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <2868419.vHvm2rOVdd@flatron> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Tomasz Figa Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Wolfram Sang , "Ben Dooks (embedded platforms)" , linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Emilio Lopez , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , Grant Likely , linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Landley , sunny-0TFLnhJekD6UEPyfVivIlAC/G2K4zDHf@public.gmane.org, shuge-0TFLnhJekD6UEPyfVivIlAC/G2K4zDHf@public.gmane.org, kevin-0TFLnhJekD6UEPyfVivIlAC/G2K4zDHf@public.gmane.org List-Id: devicetree@vger.kernel.org Hi Tomasz, On Sat, May 25, 2013 at 02:06:51PM +0200, Tomasz Figa wrote: > Hi Maxime, > > Overall the driver looks good, just some minor nitpicks inline. Thanks for the review! I'll fix the comments you had and send a new version. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com