From: Thierry Reding <thierry.reding@gmail.com>
To: Arnaud Ebalard <arno@natisbad.org>
Cc: Arnd Bergmann <arnd@arndb.de>, Andrew Lunn <andrew@lunn.ch>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Jason Cooper <jason@lakedaemon.net>,
linux-doc@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
Olivier Mouchet <olivier.mouchet@gmail.com>,
Rob Herring <rob.herring@calxeda.com>,
lm-sensors@lm-sensors.org,
Grant Likely <grant.likely@secretlab.ca>,
linux-arm-kernel@lists.infradead.org,
Rob Landley <rob@landley.net>, Jean Delvare <khali@linux-fr.org>,
Guenter Roeck <linux@roeck-us.net>,
Simon Guinot <simon.guinot@sequanux.org>
Subject: Re: [PATCHv2 0/3] Add G762/G763 PWM fan controller
Date: Tue, 28 May 2013 13:19:23 +0200 [thread overview]
Message-ID: <20130528111921.GD11547@mithrandir> (raw)
In-Reply-To: <87li6z2yxj.fsf@natisbad.org>
[-- Attachment #1: Type: text/plain, Size: 1415 bytes --]
On Tue, May 28, 2013 at 12:15:04PM +0200, Arnaud Ebalard wrote:
> Hi Arnd,
>
> Arnd Bergmann <arnd@arndb.de> writes:
>
> > On Tuesday 28 May 2013 00:02:29 Arnaud Ebalard wrote:
> >>
> >> This series adds support for GMT G762/G763. This work is based on a
> >> basic version for 2.6.31 kernel developed Olivier Mouchet for LaCie
> >> NAS. Updates have been performed to run on recent kernels. Support has
> >> been completed and additional features added: ability to configure
> >> various characteristics from .dts file, better initialization, alarms
> >> and error reporting support, gear mode, polarity, fan pulse per
> >> revolution, fan startup voltage control.
> >
> > I wonder if this could be split into two separate drivers, one for
> > the pwm subsystem, and one for a hardware-independent fan controller
> > based on the pwm interfaces.
>
> To be honest, I wouldn't even know how to start in order to do that.
> Additionally, it would be worth the effort if other drivers could be
> easily refactored using this idea. I'll let hwmon people provide some
> feedback and try and comply with their directions (based on the cpu
> cycle I can spend on this).
What Arnd proposes doesn't sounds like a very good idea. PWM-controlled
fans should be able to work just fine using a generic driver that uses
the PWM framework, similar to the PWM backlight and LED drivers.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-05-28 11:19 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-27 22:02 [PATCHv2 0/3] Add G762/G763 PWM fan controller Arnaud Ebalard
2013-05-27 22:03 ` [PATCHv2 1/3] Add support for GMT " Arnaud Ebalard
2013-05-31 22:16 ` Simon Guinot
2013-06-01 17:26 ` Arnaud Ebalard
2013-06-02 15:45 ` Arnaud Ebalard
2013-06-02 20:35 ` Guenter Roeck
2013-06-02 21:36 ` Arnaud Ebalard
2013-06-02 21:59 ` Simon Guinot
2013-06-04 6:52 ` Arnaud Ebalard
2013-06-04 21:23 ` Simon Guinot
2013-06-11 15:15 ` Guenter Roeck
2013-06-15 16:13 ` Arnaud Ebalard
2013-06-04 6:51 ` Arnaud Ebalard
2013-06-01 14:33 ` Guenter Roeck
2013-06-02 15:39 ` Arnaud Ebalard
2013-05-27 22:03 ` [PATCHv2 2/3] Add documentation for g762 driver Arnaud Ebalard
2013-05-27 22:03 ` [PATCHv2 3/3] Add DT bindings " Arnaud Ebalard
2013-05-27 22:15 ` [PATCHv2 0/3] Add G762/G763 PWM fan controller Arnd Bergmann
2013-05-28 10:15 ` Arnaud Ebalard
2013-05-28 11:19 ` Thierry Reding [this message]
2013-05-28 12:29 ` Guenter Roeck
2013-05-28 13:47 ` Thierry Reding
2013-05-28 15:42 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130528111921.GD11547@mithrandir \
--to=thierry.reding@gmail.com \
--cc=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=arno@natisbad.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=jason@lakedaemon.net \
--cc=khali@linux-fr.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=linux@roeck-us.net \
--cc=lm-sensors@lm-sensors.org \
--cc=olivier.mouchet@gmail.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=simon.guinot@sequanux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).