From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: Ulf Hansson <ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Christian Daudt <csd-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>,
Jerry Huang
<Chang-Ming.Huang-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
Wei WANG <wei_wang-kXabqFNEczNtrwSWzY7KCg@public.gmane.org>,
matt.porter-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
Kevin Liu <kliu5-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
Lars-Peter Clausen <lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>,
Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
Viresh Kumar
<viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Chris Ball <cjb-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org>,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
Bill Pemberton <wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org>,
Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Anton Vorontsov
<avorontsov-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Guennadi Liakhovetski
<g.liakhovetski-Mmb7MZpHnFY@public.gmane.org>
Subject: Re: [PATCH V3 1/3] mmc: Add size for caller in init+register
Date: Wed, 29 May 2013 16:19:28 +0200 [thread overview]
Message-ID: <201305291619.28396.arnd@arndb.de> (raw)
In-Reply-To: <CAPDyKFoPO0KTfW_i1EP8urSUT+U8yEaafrE2HdN2mmEkYCZm-w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Wednesday 29 May 2013, Ulf Hansson wrote:
> > diff --git a/drivers/mmc/host/sdhci-pltfm.h b/drivers/mmc/host/sdhci-pltfm.h
> > index 1210ed1..ed4a85d 100644
> > --- a/drivers/mmc/host/sdhci-pltfm.h
> > +++ b/drivers/mmc/host/sdhci-pltfm.h
> > @@ -27,6 +27,8 @@ struct sdhci_pltfm_host {
> > /* migrate from sdhci_of_host */
> > unsigned int clock;
> > u16 xfer_mode_shadow;
> > +
> > + unsigned long private[0] ____cacheline_aligned;
>
> Why do you need this to be "____cacheline_aligned"?
This is common practice for additional members in data structures
like this. The reason is that we append a structure which
may have larger alignment requirements than 'unsigned long'.
The kmalloc function generally returns a cache line aligned
object, so this provides the same alignment that we get
with a separate allocation.
Arnd
next prev parent reply other threads:[~2013-05-29 14:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-29 1:13 [PATCH V3 1/3] mmc: Add size for caller in init+register Christian Daudt
2013-05-29 1:13 ` [PATCH V3 2/3] ARM: mmc: bcm281xx SDHCI driver Christian Daudt
[not found] ` <1369790016-13270-2-git-send-email-csd-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2013-05-29 14:25 ` Arnd Bergmann
2013-05-29 1:13 ` [PATCH V3 3/3] ARM: mmc: bcm281xx SDHCI driver (dt mods) Christian Daudt
[not found] ` <1369790016-13270-3-git-send-email-csd-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2013-05-29 14:27 ` Arnd Bergmann
2013-05-29 12:01 ` [PATCH V3 1/3] mmc: Add size for caller in init+register Ulf Hansson
[not found] ` <CAPDyKFoPO0KTfW_i1EP8urSUT+U8yEaafrE2HdN2mmEkYCZm-w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-05-29 14:19 ` Arnd Bergmann [this message]
2013-05-29 14:25 ` Ulf Hansson
[not found] ` <1369790016-13270-1-git-send-email-csd-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2013-05-29 14:17 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201305291619.28396.arnd@arndb.de \
--to=arnd-r2ngtmty4d4@public.gmane.org \
--cc=Chang-Ming.Huang-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=avorontsov-hkdhdckH98+B+jHODAdFcQ@public.gmane.org \
--cc=cjb-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org \
--cc=csd-dY08KVG/lbpWk0Htik3J/w@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=g.liakhovetski-Mmb7MZpHnFY@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=kliu5-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org \
--cc=lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
--cc=linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matt.porter-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
--cc=s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=wei_wang-kXabqFNEczNtrwSWzY7KCg@public.gmane.org \
--cc=wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox