From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH V3 3/3] ARM: mmc: bcm281xx SDHCI driver (dt mods) Date: Wed, 29 May 2013 16:27:20 +0200 Message-ID: <201305291627.20984.arnd@arndb.de> References: <1369790016-13270-1-git-send-email-csd@broadcom.com> <1369790016-13270-3-git-send-email-csd@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1369790016-13270-3-git-send-email-csd-dY08KVG/lbpWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Christian Daudt Cc: linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jerry Huang , Wei WANG , matt.porter-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, Kevin Liu , Lars-Peter Clausen , Stephen Warren , Viresh Kumar , Chris Ball , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Sascha Hauer , Rob Herring , Bill Pemberton , Russell King , Anton Vorontsov , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Greg Kroah-Hartman , linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Guennadi Liakhovetski List-Id: devicetree@vger.kernel.org On Wednesday 29 May 2013, Christian Daudt wrote: > + sdio0: sdio@0x3f180000 { > + max-frequency = <48000000>; > + status = "okay"; > + }; > + On a general note, there is no need to duplicate both the label and the name here, one of the two is enough. The easiest way to write this in a board file is &sdio { max-frequency = <48000000>; status = "okay"; }; Your version is not wrong though, so Acked-by: Arnd Bergmann