From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Christophe PLAGNIOL-VILLARD Subject: Re: [RFC] [PATCH 1/3] of: irq: rename of_irq_count to of_irq_valid_count Date: Thu, 30 May 2013 12:28:12 +0200 Message-ID: <20130530102812.GC19834@game.jcrosoft.org> References: <20130528145219.GA30411@game.jcrosoft.org> <1369753729-12997-1-git-send-email-plagnioj@jcrosoft.com> <20130529222530.453203E16F4@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20130529222530.453203E16F4@localhost> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Grant Likely Cc: devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org, Rob Herring , Ralf Baechle List-Id: devicetree@vger.kernel.org On 23:25 Wed 29 May , Grant Likely wrote: > On Tue, 28 May 2013 17:08:47 +0200, Jean-Christophe PLAGNIOL-VILLARD wrote: > > as we count valid mapped irq not just present irq > > > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD > > Hmmm, even with it being in-accurately named, I think it is dangerous to > rename the existing function and re-use the old name. Anyone with > out-of-tree code will get the behaviour changed under their feet. I > think it would be better to drop this patch from the series. after think I known this can be consider as noisy change but I think we could rename it anyway to make it more clear and use a different name as you propose for the counting irq in PATCH 2/3 Best Regards, J.