From: Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
To: Michael Grzeschik <mgr-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
alexander.shishkin-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
balbi-l0cyMroinI0@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
Michael Grzeschik
<m.grzeschik-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Subject: Re: [PATCH 6/7] usb: chipidea: udc: add force-full-speed option
Date: Sat, 1 Jun 2013 11:21:51 +0200 [thread overview]
Message-ID: <20130601092151.GP32299@pengutronix.de> (raw)
In-Reply-To: <20130601081932.GA28181-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
On Sat, Jun 01, 2013 at 10:19:32AM +0200, Michael Grzeschik wrote:
> On Sat, Jun 01, 2013 at 09:39:33AM +0200, Sascha Hauer wrote:
> > On Fri, May 31, 2013 at 08:38:48PM +0200, Michael Grzeschik wrote:
> > > From: Michael Grzeschik <m.grzeschik-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> > >
> > > This patch makes it possible to set the chipidea udc
> > > into full-speed only mode. It can be set by the oftree
> > > property "force-full-speed".
> >
> > [...]
> >
> > > +/* force full-speed operation */
> > > +static bool full_speed;
> > > +module_param(full_speed, bool, 0444);
> > > +MODULE_PARM_DESC(full_speed, "force full-speed mode");
> > > +
> >
> > ???
>
> Right, i reworked that one to get rid of yet another of property.
> But i forgot to change the description. I will fix that, thanks.
But a module parameter limits all instances to full speed. Is that what
you want? I like a devicetree property better.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-06-01 9:21 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-31 18:38 [PATCH v6 0/7] USB: add devicetree helpers for determining dr_mode and phy_type Michael Grzeschik
[not found] ` <1370025529-7414-1-git-send-email-mgr-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-05-31 18:38 ` [PATCH 1/7] " Michael Grzeschik
[not found] ` <1370025529-7414-2-git-send-email-mgr-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-06-03 12:32 ` Alexander Shishkin
[not found] ` <8761xvjrwt.fsf-qxRn5AmX6ZD9BXuAQUXR0fooFf0ArEBIu+b9c/7xato@public.gmane.org>
2013-06-04 13:01 ` Michael Grzeschik
[not found] ` <20130604130140.GF28181-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-06-04 20:25 ` Felipe Balbi
2013-05-31 18:38 ` [PATCH 2/7] USB: chipidea: ci13xxx-imx: move static pdata into probe function Michael Grzeschik
[not found] ` <1370025529-7414-3-git-send-email-mgr-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-06-05 12:29 ` Michael Grzeschik
[not found] ` <20130605122906.GB20095-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-06-05 13:04 ` Alexander Shishkin
2013-05-31 18:38 ` [PATCH 3/7] USB: chipidea: add PTW, PTS and STS handling Michael Grzeschik
[not found] ` <1370025529-7414-4-git-send-email-mgr-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-06-03 12:35 ` Alexander Shishkin
[not found] ` <8738szjrs6.fsf-qxRn5AmX6ZD9BXuAQUXR0fooFf0ArEBIu+b9c/7xato@public.gmane.org>
2013-06-03 16:11 ` Michael Grzeschik
[not found] ` <20130603161136.GB28181-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-06-04 9:22 ` Alexander Shishkin
2013-06-06 10:54 ` Michael Grzeschik
2013-05-31 18:38 ` [PATCH 4/7] USB chipidea: introduce dual role mode pdata flags Michael Grzeschik
[not found] ` <1370025529-7414-5-git-send-email-mgr-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-06-03 12:37 ` Alexander Shishkin
[not found] ` <87zjv7id52.fsf-qxRn5AmX6ZD9BXuAQUXR0fooFf0ArEBIu+b9c/7xato@public.gmane.org>
2013-06-04 1:42 ` Peter Chen
[not found] ` <CAL411-pMnJC55M3n5bAuffH3pwRZTzhBfDiEfT+egtGN29c7uw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-06-04 9:31 ` Alexander Shishkin
[not found] ` <87ehcii5n0.fsf-qxRn5AmX6ZD9BXuAQUXR0fooFf0ArEBIu+b9c/7xato@public.gmane.org>
2013-06-04 10:09 ` Peter Chen
[not found] ` <CAL411-pyrFXxyEX_GAFRS5ubh_Pf2yWLZXYC3PJevu1WSJS78g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-06-04 11:09 ` Alexander Shishkin
2013-05-31 18:38 ` [PATCH 5/7] USB chipidea i.MX: use devm_usb_get_phy_by_phandle to get phy Michael Grzeschik
[not found] ` <1370025529-7414-6-git-send-email-mgr-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-05-31 19:23 ` Sergei Shtylyov
2013-06-03 12:39 ` Alexander Shishkin
2013-05-31 18:38 ` [PATCH 6/7] usb: chipidea: udc: add force-full-speed option Michael Grzeschik
[not found] ` <1370025529-7414-7-git-send-email-mgr-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-06-01 7:39 ` Sascha Hauer
[not found] ` <20130601073933.GK32299-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-06-01 8:19 ` Michael Grzeschik
[not found] ` <20130601081932.GA28181-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-06-01 9:21 ` Sascha Hauer [this message]
[not found] ` <20130601092151.GP32299-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-06-03 12:40 ` Alexander Shishkin
2013-05-31 18:38 ` [PATCH 7/7] usb: chipidea: usbmisc: use module_platform_driver Michael Grzeschik
[not found] ` <1370025529-7414-8-git-send-email-mgr-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-06-03 12:41 ` Alexander Shishkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130601092151.GP32299@pengutronix.de \
--to=s.hauer-bicnvbalz9megne8c9+irq@public.gmane.org \
--cc=alexander.shishkin-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=balbi-l0cyMroinI0@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=m.grzeschik-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=mgr-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).