From: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Bryan Wu <cooloney-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Milo Kim <Milo.Kim-l0cyMroinI0@public.gmane.org>,
Linus Walleij
<linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>,
"devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org"
<devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>,
Gabriel Fernandez
<gabriel.fernandez.st-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH] ARM: ux500: register LP5521 LEDs in the device tree
Date: Mon, 3 Jun 2013 09:18:05 +0100 [thread overview]
Message-ID: <20130603081805.GC3370@gmail.com> (raw)
In-Reply-To: <CAK5ve-+oJL0fbtM=5xRSBjCztX1fP-fcwUvZurnj42hiXR5X+Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Fri, 31 May 2013, Bryan Wu wrote:
> On Wed, May 22, 2013 at 1:12 AM, Linus Walleij
> <linus.walleij@stericsson.com> wrote:
> > From: Linus Walleij <linus.walleij@linaro.org>
> >
> > Based on pending device tree support in the LP55xx drivers
> > we can add the correct LED and channel configuration from the
> > ux500 device tree for all HREF variants.
> >
> > Cc: Milo Kim <Milo.Kim@ti.com>
> > Cc: Bryan Wu <cooloney@gmail.com>
> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> > ---
> > arch/arm/boot/dts/href.dtsi | 38 ++++++++++++++++++++++++++++++++------
> > 1 file changed, 32 insertions(+), 6 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/href.dtsi b/arch/arm/boot/dts/href.dtsi
> > index 62523f6..e315429 100644
> > --- a/arch/arm/boot/dts/href.dtsi
> > +++ b/arch/arm/boot/dts/href.dtsi
> > @@ -63,16 +63,42 @@
> > };
> >
> > i2c@80128000 {
> > - lp5521@0x33 {
> > - compatible = "lp5521";
> > + lp5521@33 {
>
> Is this right, I guess it should be still "lp5521@0x33", although it's
> just a name.
What makes you say that Bryan?
All other nodes drop the '0x', as it's implied.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss
next prev parent reply other threads:[~2013-06-03 8:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-22 8:12 [PATCH] ARM: ux500: register LP5521 LEDs in the device tree Linus Walleij
2013-05-22 23:14 ` Kim, Milo
[not found] ` <1369210331-18545-1-git-send-email-linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>
2013-05-31 17:37 ` Bryan Wu
[not found] ` <CAK5ve-+oJL0fbtM=5xRSBjCztX1fP-fcwUvZurnj42hiXR5X+Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-06-03 8:18 ` Lee Jones [this message]
[not found] ` <20130603081805.GC3370-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-06-03 17:29 ` Bryan Wu
[not found] ` <CAK5ve-+ykvTfpfsyAfnoURwuZt1nF4aFPGU5yQa0HXXBmWW_9Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-06-04 7:35 ` Lee Jones
[not found] ` <20130604073507.GL3370-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-06-04 17:33 ` Bryan Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130603081805.GC3370@gmail.com \
--to=lee.jones-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
--cc=Milo.Kim-l0cyMroinI0@public.gmane.org \
--cc=cooloney-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=gabriel.fernandez.st-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).