From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodolfo Giometti Subject: Re: [PATCH v2] pps-gpio: add device-tree binding and support Date: Mon, 3 Jun 2013 14:04:45 +0200 Message-ID: <20130603120445.GF4393@enneenne.com> References: <1588516.WvWWFWzAui@wuerfel> <1370083449-11986-1-git-send-email-jlu@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1370083449-11986-1-git-send-email-jlu-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Jan Luebbe Cc: linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , Grant Likely , Andrew Morton List-Id: devicetree@vger.kernel.org On Sat, Jun 01, 2013 at 12:44:09PM +0200, Jan Luebbe wrote: > Instead of allocating a struct pps_gpio_platform_data in the DT case, store > the necessary information in struct pps_gpio_device_data itself. This avoids > an additional allocation and the ifdef. It also gets rid of some indirection. > > Also use dev_err instead of pr_err in the changed code. > > Signed-off-by: Jan Luebbe Acked-by: Rodolfo Giometti -- GNU/Linux Solutions e-mail: giometti-AVVDYK/kqiJWk0Htik3J/w@public.gmane.org Linux Device Driver giometti-k2GhghHVRtY@public.gmane.org Embedded Systems phone: +39 349 2432127 UNIX programming skype: rodolfo.giometti Freelance ICT Italia - Consulente ICT Italia - www.consulenti-ict.it