From: Baruch Siach <baruch@tkos.co.il>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: Jamie Iles <jamie@jamieiles.com>, Arnd Bergmann <arnd@arndb.de>,
devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org,
Rob Herring <rob.herring@calxeda.com>,
John Stultz <john.stultz@linaro.org>,
Dinh Nguyen <dinguyen@altera.com>,
Grant Likely <grant.likely@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] clocksource: dw_apb_timer_of: use clocksource_of_init
Date: Tue, 4 Jun 2013 07:36:20 +0300 [thread overview]
Message-ID: <20130604043620.GU11798@tarshish> (raw)
In-Reply-To: <201306032159.55685.heiko@sntech.de>
Hi Heiko,
On Mon, Jun 03, 2013 at 09:59:55PM +0200, Heiko Stübner wrote:
> dw_apb_timer_init used to search the devicetree for matching timer
> devices, making calls to it from board files necessary.
>
> Change the dw_apb_timer_init to work with CLOCKSOURCE_OF_DECLARE.
> With this change the function gets called once for each timer node
> and tracks these number of calls to attach clockevent and clocksource
> devices to the nodes.
>
> Also remove the calls to dw_apb_timer_init from all previous users, as
> clocksource_of_init is the default for init_time now.
>
> Tested on the upcoming rk3066 code.
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> Acked-by: Rob Herring <rob.herring@calxeda.com>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
> ---
> arch/arm/mach-picoxcell/Kconfig | 1 +
> arch/arm/mach-picoxcell/common.c | 2 -
> arch/arm/mach-socfpga/Kconfig | 1 +
> arch/arm/mach-socfpga/socfpga.c | 2 -
> drivers/clocksource/dw_apb_timer_of.c | 41 ++++++++++++++++-----------------
> include/linux/dw_apb_timer.h | 1 -
> 6 files changed, 22 insertions(+), 26 deletions(-)
>
> diff --git a/arch/arm/mach-picoxcell/Kconfig b/arch/arm/mach-picoxcell/Kconfig
> index 13bae78..3ef6bbe 100644
> --- a/arch/arm/mach-picoxcell/Kconfig
> +++ b/arch/arm/mach-picoxcell/Kconfig
> @@ -6,6 +6,7 @@ config ARCH_PICOXCELL
> select CPU_V6K
> select DW_APB_TIMER
> select DW_APB_TIMER_OF
> + select CLKSRC_OF
Shouldn't DW_APB_TIMER 'select CLKSRC_OF if OF' instead of selecting is for
each and every platform? While at it we can do the same to DW_APB_TIMER_OF.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
next prev parent reply other threads:[~2013-06-04 4:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 19:57 [PATCH 0/3] dw_apb_timer: osc as sched_clock, clocks and clocksource_of support Heiko Stübner
2013-06-03 19:58 ` [PATCH 2/3] clocksource: dw_apb_timer_of: add clock-handling Heiko Stübner
[not found] ` <201306032157.40488.heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
2013-06-03 19:58 ` [PATCH 1/3] clocksource: dw_apb_timer_of: use the clocksource as sched clock if necessary Heiko Stübner
2013-06-03 19:59 ` [PATCH 3/3] clocksource: dw_apb_timer_of: use clocksource_of_init Heiko Stübner
2013-06-04 4:36 ` Baruch Siach [this message]
2013-06-04 7:57 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130604043620.GU11798@tarshish \
--to=baruch@tkos.co.il \
--cc=arnd@arndb.de \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dinguyen@altera.com \
--cc=grant.likely@linaro.org \
--cc=heiko@sntech.de \
--cc=jamie@jamieiles.com \
--cc=john.stultz@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).