* [PATCH] mfd: DT bindings for the palmas family MFD @ 2013-06-03 12:08 J Keerthy 2013-06-03 14:18 ` Lee Jones 0 siblings, 1 reply; 7+ messages in thread From: J Keerthy @ 2013-06-03 12:08 UTC (permalink / raw) To: linux-kernel Cc: linux-doc, devicetree-discuss, swarren, broonie, rob.herring, rob, mturquette, sameo, wim, lgirdwood, gg, t-kristo, J Keerthy, Ian Lartey From: Graeme Gregory <gg@slimlogic.co.uk> Add the various binding files for the palmas family of chips. There is a top level MFD binding then a seperate binding for regulators IP blocks on chips. Signed-off-by: Graeme Gregory <gg@slimlogic.co.uk> Signed-off-by: J Keerthy <j-keerthy@ti.com> Signed-off-by: Ian Lartey <ian@slimlogic.co.uk> --- Documentation/devicetree/bindings/mfd/palmas.txt | 49 ++++++ .../devicetree/bindings/regulator/palmas-pmic.txt | 165 ++++++++++++++++++++ 2 files changed, 214 insertions(+), 0 deletions(-) create mode 100644 Documentation/devicetree/bindings/mfd/palmas.txt create mode 100644 Documentation/devicetree/bindings/regulator/palmas-pmic.txt diff --git a/Documentation/devicetree/bindings/mfd/palmas.txt b/Documentation/devicetree/bindings/mfd/palmas.txt new file mode 100644 index 0000000..c6c5e78 --- /dev/null +++ b/Documentation/devicetree/bindings/mfd/palmas.txt @@ -0,0 +1,49 @@ +* palmas device tree bindings + +The TI palmas family current members :- +twl6035 (palmas) +twl6037 (palmas) +tps65913 (palmas) +tps65914 (palmas) + +Required properties: +- compatible : Should be from the list + ti,twl6035 + ti,twl6036 + ti,twl6037 + ti,tps65913 + ti,tps65914 + ti,tps80036 +and also the generic series names + ti,palmas +- interrupt-controller : palmas has its own internal IRQs +- #interrupt-cells : should be set to 2 for IRQ number and flags + The first cell is the IRQ number. + The second cell is the flags, encoded as the trigger masks from + Documentation/devicetree/bindings/interrupts.txt +- interrupt-parent : The parent interrupt controller. + +Optional properties: + ti,mux_padX : set the pad register X (1-2) to the correct muxing for the + hardware, if not set will use muxing in OTP. + +Example: + +palmas { + compatible = "ti,twl6035", "ti,palmas"; + reg = <0x48> + interrupt-parent = <&intc>; + interrupt-controller; + #interrupt-cells = <2>; + + ti,mux-pad1 = <0>; + ti,mux-pad2 = <0>; + + #address-cells = <1>; + #size-cells = <0>; + + pmic { + compatible = "ti,twl6035-pmic", "ti,palmas-pmic"; + .... + }; +} diff --git a/Documentation/devicetree/bindings/regulator/palmas-pmic.txt b/Documentation/devicetree/bindings/regulator/palmas-pmic.txt new file mode 100644 index 0000000..f7bbc3e --- /dev/null +++ b/Documentation/devicetree/bindings/regulator/palmas-pmic.txt @@ -0,0 +1,165 @@ +* palmas regulator IP block devicetree bindings + +Required properties: +- compatible : Should be from the list + ti,twl6035-pmic + ti,twl6036-pmic + ti,twl6037-pmic + ti,tps65913-pmic + ti,tps65914-pmic +and also the generic series names + ti,palmas-pmic + +Optional properties: +- ti,ldo6-vibrator : ldo6 is in vibrator mode + +Optional nodes: +- regulators : should contain the constrains and init information for the + regulators. It should contain a subnode per regulator from the + list. + For ti,palmas-pmic - smps12, smps123, smps3 depending on OTP, + smps45, smps457, smps7 depending on varient, smps6, smps[8-10], + ldo[1-9], ldoln, ldousb + + optional chip specific regulator fields :- + ti,warm-reset - maintain voltage during warm reset(boolean) + ti,roof-floor - control voltage selection by pin(boolean) + ti,sleep-mode - mode to adopt in pmic sleep 0 - off, 1 - auto, + 2 - eco, 3 - forced pwm + ti,tstep - slope control 0 - Jump, 1 10mV/us, 2 5mV/us, 3 2.5mV/us + ti,smps-range - OTP has the wrong range set for the hardware so override + 0 - low range, 1 - high range + +Example: + +pmic@0 { + compatible = "ti,twl6035-pmic", "ti,palmas-pmic"; + interrupt-parent = <&palmas>; + interrupts = <14 0>; + interrupt-name = "short-irq"; + + ti,ldo6_vibrator; + + regulators { + smps12_reg : smps12 { + regulator-name = "smps12"; + regulator-min-microvolt = < 600000>; + regulator-max-microvolt = <1500000>; + regulator-always-on; + regulator-boot-on; + ti,warm-reset; + ti,roof-floor; + ti,mode-sleep = <0>; + ti,tstep = <0>; + ti,smps-range = <1>; + }; + + smps3_reg: smps3 { + regulator-name = "smps3"; + regulator-min-microvolt = < 600000>; + regulator-max-microvolt = <1310000>; + }; + + smps45_reg: smps45 { + regulator-name = "smps45"; + regulator-min-microvolt = < 600000>; + regulator-max-microvolt = <1310000>; + }; + + smps6_reg: smps6 { + regulator-name = "smps6"; + regulator-min-microvolt = <1200000>; + regulator-max-microvolt = <1200000>; + }; + + smps7_reg: smps7 { + regulator-name = "smps7"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + }; + + smps8_reg: smps8 { + regulator-name = "smps8"; + regulator-min-microvolt = < 600000>; + regulator-max-microvolt = <1310000>; + }; + + smps9_reg: smps9 { + regulator-name = "smps9"; + regulator-min-microvolt = <2100000>; + regulator-max-microvolt = <2100000>; + }; + + smps10_reg: smps10 { + regulator-name = "smps10"; + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + }; + + ldo1_reg: ldo1 { + regulator-name = "ldo1"; + regulator-min-microvolt = <2800000>; + regulator-max-microvolt = <2800000>; + }; + + ldo2_reg: ldo2 { + regulator-name = "ldo2"; + regulator-min-microvolt = <2900000>; + regulator-max-microvolt = <2900000>; + }; + + ldo3_reg: ldo3 { + regulator-name = "ldo3"; + regulator-min-microvolt = <3000000>; + regulator-max-microvolt = <3000000>; + }; + + ldo4_reg: ldo4 { + regulator-name = "ldo4"; + regulator-min-microvolt = <2200000>; + regulator-max-microvolt = <2200000>; + }; + + ldo5_reg: ldo5 { + regulator-name = "ldo5"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + }; + + ldo6_reg: ldo6 { + regulator-name = "ldo6"; + regulator-min-microvolt = <1500000>; + regulator-max-microvolt = <1500000>; + }; + + ldo7_reg: ldo7 { + regulator-name = "ldo7"; + regulator-min-microvolt = <1500000>; + regulator-max-microvolt = <1500000>; + }; + + ldo8_reg: ldo8 { + regulator-name = "ldo8"; + regulator-min-microvolt = <1500000>; + regulator-max-microvolt = <1500000>; + }; + + ldo9_reg: ldo9 { + regulator-name = "ldo9"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + }; + + ldoln_reg: ldoln { + regulator-name = "ldoln"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + }; + + ldousb_reg: ldousb { + regulator-name = "ldousb"; + regulator-min-microvolt = <3250000>; + regulator-max-microvolt = <3250000>; + }; + }; +}; -- 1.7.5.4 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] mfd: DT bindings for the palmas family MFD 2013-06-03 12:08 [PATCH] mfd: DT bindings for the palmas family MFD J Keerthy @ 2013-06-03 14:18 ` Lee Jones 2013-06-03 20:38 ` Stephen Warren ` (2 more replies) 0 siblings, 3 replies; 7+ messages in thread From: Lee Jones @ 2013-06-03 14:18 UTC (permalink / raw) To: J Keerthy Cc: linux-kernel, linux-doc, devicetree-discuss, swarren, broonie, rob.herring, rob, mturquette, sameo, wim, lgirdwood, gg, t-kristo, Ian Lartey On Mon, 03 Jun 2013, J Keerthy wrote: > From: Graeme Gregory <gg@slimlogic.co.uk> > > Add the various binding files for the palmas family of chips. There is a > top level MFD binding then a seperate binding for regulators IP blocks on chips. > > Signed-off-by: Graeme Gregory <gg@slimlogic.co.uk> > Signed-off-by: J Keerthy <j-keerthy@ti.com> > Signed-off-by: Ian Lartey <ian@slimlogic.co.uk> > --- > Documentation/devicetree/bindings/mfd/palmas.txt | 49 ++++++ > .../devicetree/bindings/regulator/palmas-pmic.txt | 165 ++++++++++++++++++++ > 2 files changed, 214 insertions(+), 0 deletions(-) > create mode 100644 Documentation/devicetree/bindings/mfd/palmas.txt > create mode 100644 Documentation/devicetree/bindings/regulator/palmas-pmic.txt > > diff --git a/Documentation/devicetree/bindings/mfd/palmas.txt b/Documentation/devicetree/bindings/mfd/palmas.txt > new file mode 100644 > index 0000000..c6c5e78 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/palmas.txt > @@ -0,0 +1,49 @@ > +* palmas device tree bindings > + > +The TI palmas family current members :- > +twl6035 (palmas) > +twl6037 (palmas) > +tps65913 (palmas) > +tps65914 (palmas) > + > +Required properties: > +- compatible : Should be from the list > + ti,twl6035 > + ti,twl6036 > + ti,twl6037 > + ti,tps65913 > + ti,tps65914 > + ti,tps80036 > +and also the generic series names > + ti,palmas > +- interrupt-controller : palmas has its own internal IRQs > +- #interrupt-cells : should be set to 2 for IRQ number and flags > + The first cell is the IRQ number. > + The second cell is the flags, encoded as the trigger masks from > + Documentation/devicetree/bindings/interrupts.txt > +- interrupt-parent : The parent interrupt controller. > + > +Optional properties: > + ti,mux_padX : set the pad register X (1-2) to the correct muxing for the > + hardware, if not set will use muxing in OTP. > + > +Example: > + > +palmas { Should this be 'palmas@48 {', as it has an address? > + compatible = "ti,twl6035", "ti,palmas"; > + reg = <0x48> > + interrupt-parent = <&intc>; > + interrupt-controller; > + #interrupt-cells = <2>; > + > + ti,mux-pad1 = <0>; > + ti,mux-pad2 = <0>; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + pmic { > + compatible = "ti,twl6035-pmic", "ti,palmas-pmic"; > + .... > + }; > +} > diff --git a/Documentation/devicetree/bindings/regulator/palmas-pmic.txt b/Documentation/devicetree/bindings/regulator/palmas-pmic.txt > new file mode 100644 > index 0000000..f7bbc3e > --- /dev/null > +++ b/Documentation/devicetree/bindings/regulator/palmas-pmic.txt > @@ -0,0 +1,165 @@ > +* palmas regulator IP block devicetree bindings > + > +Required properties: > +- compatible : Should be from the list > + ti,twl6035-pmic > + ti,twl6036-pmic > + ti,twl6037-pmic > + ti,tps65913-pmic > + ti,tps65914-pmic > +and also the generic series names > + ti,palmas-pmic > + > +Optional properties: > +- ti,ldo6-vibrator : ldo6 is in vibrator mode > + > +Optional nodes: > +- regulators : should contain the constrains and init information for the > + regulators. It should contain a subnode per regulator from the > + list. > + For ti,palmas-pmic - smps12, smps123, smps3 depending on OTP, > + smps45, smps457, smps7 depending on varient, smps6, smps[8-10], > + ldo[1-9], ldoln, ldousb > + > + optional chip specific regulator fields :- > + ti,warm-reset - maintain voltage during warm reset(boolean) Pushing the boat out a bit here, but is it possible to reuse 'regulator-always-on' for this? > + ti,roof-floor - control voltage selection by pin(boolean) Is this the same as a GPIO regulator? If so, you might not need to add superfluous vendor specific properties. See: Documentation/devicetree/bindings/regulator/gpio-regulator.txt > + ti,sleep-mode - mode to adopt in pmic sleep 0 - off, 1 - auto, > + 2 - eco, 3 - forced pwm I've seen lots of sleep-mode properties, can't we define a generic one? > + ti,tstep - slope control 0 - Jump, 1 10mV/us, 2 5mV/us, 3 2.5mV/us > + ti,smps-range - OTP has the wrong range set for the hardware so override > + 0 - low range, 1 - high range > + > +Example: > + > +pmic@0 { May as well drop the '@0' here unless it's meaningful. > + compatible = "ti,twl6035-pmic", "ti,palmas-pmic"; > + interrupt-parent = <&palmas>; > + interrupts = <14 0>; Use the defines found in: arch/arm/boot/dts/include/dt-bindings/interrupt-controller/irq.h > + interrupt-name = "short-irq"; > + > + ti,ldo6_vibrator; DT doesn't like '_'s, use a '-'s instead. > + regulators { > + smps12_reg : smps12 { > + regulator-name = "smps12"; > + regulator-min-microvolt = < 600000>; > + regulator-max-microvolt = <1500000>; > + regulator-always-on; > + regulator-boot-on; > + ti,warm-reset; Hmm.. I see you're using 'regulator-always-on' and 'ti,warm-reset' here. Is there every a case where there is one without the other? > + ti,roof-floor; > + ti,mode-sleep = <0>; > + ti,tstep = <0>; > + ti,smps-range = <1>; > + }; > + > + smps3_reg: smps3 { > + regulator-name = "smps3"; > + regulator-min-microvolt = < 600000>; > + regulator-max-microvolt = <1310000>; > + }; Wow, this is a big example. I don't think you need to provide more than 1 or 2 of these _reg nodes. > + smps45_reg: smps45 { > + regulator-name = "smps45"; > + regulator-min-microvolt = < 600000>; > + regulator-max-microvolt = <1310000>; > + }; > + > + smps6_reg: smps6 { > + regulator-name = "smps6"; > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <1200000>; > + }; > + > + smps7_reg: smps7 { > + regulator-name = "smps7"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + }; > + > + smps8_reg: smps8 { > + regulator-name = "smps8"; > + regulator-min-microvolt = < 600000>; > + regulator-max-microvolt = <1310000>; > + }; > + > + smps9_reg: smps9 { > + regulator-name = "smps9"; > + regulator-min-microvolt = <2100000>; > + regulator-max-microvolt = <2100000>; > + }; > + > + smps10_reg: smps10 { > + regulator-name = "smps10"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + }; > + > + ldo1_reg: ldo1 { > + regulator-name = "ldo1"; > + regulator-min-microvolt = <2800000>; > + regulator-max-microvolt = <2800000>; > + }; > + > + ldo2_reg: ldo2 { > + regulator-name = "ldo2"; > + regulator-min-microvolt = <2900000>; > + regulator-max-microvolt = <2900000>; > + }; > + > + ldo3_reg: ldo3 { > + regulator-name = "ldo3"; > + regulator-min-microvolt = <3000000>; > + regulator-max-microvolt = <3000000>; > + }; > + > + ldo4_reg: ldo4 { > + regulator-name = "ldo4"; > + regulator-min-microvolt = <2200000>; > + regulator-max-microvolt = <2200000>; > + }; > + > + ldo5_reg: ldo5 { > + regulator-name = "ldo5"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + }; > + > + ldo6_reg: ldo6 { > + regulator-name = "ldo6"; > + regulator-min-microvolt = <1500000>; > + regulator-max-microvolt = <1500000>; > + }; > + > + ldo7_reg: ldo7 { > + regulator-name = "ldo7"; > + regulator-min-microvolt = <1500000>; > + regulator-max-microvolt = <1500000>; > + }; > + > + ldo8_reg: ldo8 { > + regulator-name = "ldo8"; > + regulator-min-microvolt = <1500000>; > + regulator-max-microvolt = <1500000>; > + }; > + > + ldo9_reg: ldo9 { > + regulator-name = "ldo9"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + }; > + > + ldoln_reg: ldoln { > + regulator-name = "ldoln"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + }; > + > + ldousb_reg: ldousb { > + regulator-name = "ldousb"; > + regulator-min-microvolt = <3250000>; > + regulator-max-microvolt = <3250000>; > + }; > + }; > +}; -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] mfd: DT bindings for the palmas family MFD 2013-06-03 14:18 ` Lee Jones @ 2013-06-03 20:38 ` Stephen Warren 2013-06-04 6:24 ` J, KEERTHY 2013-06-04 7:21 ` Lee Jones 2013-06-04 5:28 ` J, KEERTHY [not found] ` <20130603141851.GG3370-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2 siblings, 2 replies; 7+ messages in thread From: Stephen Warren @ 2013-06-03 20:38 UTC (permalink / raw) To: Lee Jones Cc: J Keerthy, linux-kernel, linux-doc, devicetree-discuss, broonie, rob.herring, rob, mturquette, sameo, wim, lgirdwood, gg, t-kristo, Ian Lartey On 06/03/2013 08:18 AM, Lee Jones wrote: > On Mon, 03 Jun 2013, J Keerthy wrote: >> Add the various binding files for the palmas family of chips. There is a >> top level MFD binding then a seperate binding for regulators IP blocks on chips. >> diff --git a/Documentation/devicetree/bindings/mfd/palmas.txt b/Documentation/devicetree/bindings/mfd/palmas.txt >> +Example: >> + >> +palmas { > > Should this be 'palmas@48 {', as it has an address? It's common to only include the unit-address (@48) if it's needed to make the node name unique (i.e. if you had multiple palmas devices). >> diff --git a/Documentation/devicetree/bindings/regulator/palmas-pmic.txt b/Documentation/devicetree/bindings/regulator/palmas-pmic.txt > See: Documentation/devicetree/bindings/regulator/gpio-regulator.txt > >> + ti,sleep-mode - mode to adopt in pmic sleep 0 - off, 1 - auto, >> + 2 - eco, 3 - forced pwm > > I've seen lots of sleep-mode properties, can't we define a generic > one? Isn't it HW-specific? ^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH] mfd: DT bindings for the palmas family MFD 2013-06-03 20:38 ` Stephen Warren @ 2013-06-04 6:24 ` J, KEERTHY 2013-06-04 7:21 ` Lee Jones 1 sibling, 0 replies; 7+ messages in thread From: J, KEERTHY @ 2013-06-04 6:24 UTC (permalink / raw) To: Stephen Warren, Lee Jones Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, broonie@opensource.wolfsonmicro.com, rob.herring@calxeda.com, rob@landley.net, sameo@linux.intel.com, wim@iguana.be, lgirdwood@gmail.com, gg@slimlogic.co.uk, Kristo, Tero, Ian Lartey > -----Original Message----- > From: Stephen Warren [mailto:swarren@wwwdotorg.org] > Sent: Tuesday, June 04, 2013 2:09 AM > To: Lee Jones > Cc: J, KEERTHY; linux-kernel@vger.kernel.org; linux- > doc@vger.kernel.org; devicetree-discuss@lists.ozlabs.org; > broonie@opensource.wolfsonmicro.com; rob.herring@calxeda.com; > rob@landley.net; mturquette@linaro.org; sameo@linux.intel.com; > wim@iguana.be; lgirdwood@gmail.com; gg@slimlogic.co.uk; Kristo, Tero; > Ian Lartey > Subject: Re: [PATCH] mfd: DT bindings for the palmas family MFD > > On 06/03/2013 08:18 AM, Lee Jones wrote: > > On Mon, 03 Jun 2013, J Keerthy wrote: > >> Add the various binding files for the palmas family of chips. There > >> is a top level MFD binding then a seperate binding for regulators IP > blocks on chips. > > >> diff --git a/Documentation/devicetree/bindings/mfd/palmas.txt > >> b/Documentation/devicetree/bindings/mfd/palmas.txt > > >> +Example: > >> + > >> +palmas { > > > > Should this be 'palmas@48 {', as it has an address? > > It's common to only include the unit-address (@48) if it's needed to > make the node name unique (i.e. if you had multiple palmas devices). Yeah. We generally have one Palmas device. > > >> diff --git > >> a/Documentation/devicetree/bindings/regulator/palmas-pmic.txt > >> b/Documentation/devicetree/bindings/regulator/palmas-pmic.txt > > > See: Documentation/devicetree/bindings/regulator/gpio-regulator.txt > > > >> + ti,sleep-mode - mode to adopt in pmic sleep 0 - off, 1 - > auto, > >> + 2 - eco, 3 - forced pwm > > > > I've seen lots of sleep-mode properties, can't we define a generic > > one? > > Isn't it HW-specific? Yeah. Hence it is ti,sleep-mode. Regards, Keerthy ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] mfd: DT bindings for the palmas family MFD 2013-06-03 20:38 ` Stephen Warren 2013-06-04 6:24 ` J, KEERTHY @ 2013-06-04 7:21 ` Lee Jones 1 sibling, 0 replies; 7+ messages in thread From: Lee Jones @ 2013-06-04 7:21 UTC (permalink / raw) To: Stephen Warren Cc: J Keerthy, linux-kernel, linux-doc, devicetree-discuss, broonie, rob.herring, rob, mturquette, sameo, wim, lgirdwood, gg, t-kristo, Ian Lartey On Mon, 03 Jun 2013, Stephen Warren wrote: > On 06/03/2013 08:18 AM, Lee Jones wrote: > > On Mon, 03 Jun 2013, J Keerthy wrote: > >> Add the various binding files for the palmas family of chips. There is a > >> top level MFD binding then a seperate binding for regulators IP blocks on chips. > > >> diff --git a/Documentation/devicetree/bindings/mfd/palmas.txt b/Documentation/devicetree/bindings/mfd/palmas.txt > > >> +Example: > >> + > >> +palmas { > > > > Should this be 'palmas@48 {', as it has an address? > > It's common to only include the unit-address (@48) if it's needed to > make the node name unique (i.e. if you had multiple palmas devices). I was working on the basis of, if it has a 'reg' value, it should be highlighted in the node name, but if this is the common way of doing things then fair enough. > >> diff --git a/Documentation/devicetree/bindings/regulator/palmas-pmic.txt b/Documentation/devicetree/bindings/regulator/palmas-pmic.txt > > > See: Documentation/devicetree/bindings/regulator/gpio-regulator.txt > > > >> + ti,sleep-mode - mode to adopt in pmic sleep 0 - off, 1 - auto, > >> + 2 - eco, 3 - forced pwm > > > > I've seen lots of sleep-mode properties, can't we define a generic > > one? > > Isn't it HW-specific? Yes, they're not all identical. I haven't studied them all in detail, but I assumed a we would be able to do something in order to consolidate them somewhat. If they are vastly different then no problem, it was just an idea to cut down on vendor specific properties. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog ^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH] mfd: DT bindings for the palmas family MFD 2013-06-03 14:18 ` Lee Jones 2013-06-03 20:38 ` Stephen Warren @ 2013-06-04 5:28 ` J, KEERTHY [not found] ` <20130603141851.GG3370-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2 siblings, 0 replies; 7+ messages in thread From: J, KEERTHY @ 2013-06-04 5:28 UTC (permalink / raw) To: Lee Jones Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, swarren@wwwdotorg.org, broonie@opensource.wolfsonmicro.com, rob.herring@calxeda.com, rob@landley.net, mturquette@linaro.org, sameo@linux.intel.com, wim@iguana.be, lgirdwood@gmail.com, gg@slimlogic.co.uk, Kristo, Tero, Ian Lartey Hello Lee Jones, Thanks for the quick review. > -----Original Message----- > From: Lee Jones [mailto:lee.jones@linaro.org] > Sent: Monday, June 03, 2013 7:49 PM > To: J, KEERTHY > Cc: linux-kernel@vger.kernel.org; linux-doc@vger.kernel.org; > devicetree-discuss@lists.ozlabs.org; swarren@wwwdotorg.org; > broonie@opensource.wolfsonmicro.com; rob.herring@calxeda.com; > rob@landley.net; mturquette@linaro.org; sameo@linux.intel.com; > wim@iguana.be; lgirdwood@gmail.com; gg@slimlogic.co.uk; Kristo, Tero; > Ian Lartey > Subject: Re: [PATCH] mfd: DT bindings for the palmas family MFD > > On Mon, 03 Jun 2013, J Keerthy wrote: > > > From: Graeme Gregory <gg@slimlogic.co.uk> > > > > Add the various binding files for the palmas family of chips. There > is > > a top level MFD binding then a seperate binding for regulators IP > blocks on chips. > > > > Signed-off-by: Graeme Gregory <gg@slimlogic.co.uk> > > Signed-off-by: J Keerthy <j-keerthy@ti.com> > > Signed-off-by: Ian Lartey <ian@slimlogic.co.uk> > > --- > > Documentation/devicetree/bindings/mfd/palmas.txt | 49 ++++++ > > .../devicetree/bindings/regulator/palmas-pmic.txt | 165 > > ++++++++++++++++++++ > > 2 files changed, 214 insertions(+), 0 deletions(-) create mode > > 100644 Documentation/devicetree/bindings/mfd/palmas.txt > > create mode 100644 > > Documentation/devicetree/bindings/regulator/palmas-pmic.txt > > > > diff --git a/Documentation/devicetree/bindings/mfd/palmas.txt > > b/Documentation/devicetree/bindings/mfd/palmas.txt > > new file mode 100644 > > index 0000000..c6c5e78 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mfd/palmas.txt > > @@ -0,0 +1,49 @@ > > +* palmas device tree bindings > > + > > +The TI palmas family current members :- > > +twl6035 (palmas) > > +twl6037 (palmas) > > +tps65913 (palmas) > > +tps65914 (palmas) > > + > > +Required properties: > > +- compatible : Should be from the list > > + ti,twl6035 > > + ti,twl6036 > > + ti,twl6037 > > + ti,tps65913 > > + ti,tps65914 > > + ti,tps80036 > > +and also the generic series names > > + ti,palmas > > +- interrupt-controller : palmas has its own internal IRQs > > +- #interrupt-cells : should be set to 2 for IRQ number and flags > > + The first cell is the IRQ number. > > + The second cell is the flags, encoded as the trigger masks from > > + Documentation/devicetree/bindings/interrupts.txt > > +- interrupt-parent : The parent interrupt controller. > > + > > +Optional properties: > > + ti,mux_padX : set the pad register X (1-2) to the correct muxing > for the > > + hardware, if not set will use muxing in OTP. > > + > > +Example: > > + > > +palmas { > > Should this be 'palmas@48 {', as it has an address? > > > + compatible = "ti,twl6035", "ti,palmas"; > > + reg = <0x48> > > + interrupt-parent = <&intc>; > > + interrupt-controller; > > + #interrupt-cells = <2>; > > + > > + ti,mux-pad1 = <0>; > > + ti,mux-pad2 = <0>; > > + > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + pmic { > > + compatible = "ti,twl6035-pmic", "ti,palmas-pmic"; > > + .... > > + }; > > +} > > diff --git > > a/Documentation/devicetree/bindings/regulator/palmas-pmic.txt > > b/Documentation/devicetree/bindings/regulator/palmas-pmic.txt > > new file mode 100644 > > index 0000000..f7bbc3e > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/regulator/palmas-pmic.txt > > @@ -0,0 +1,165 @@ > > +* palmas regulator IP block devicetree bindings > > + > > +Required properties: > > +- compatible : Should be from the list > > + ti,twl6035-pmic > > + ti,twl6036-pmic > > + ti,twl6037-pmic > > + ti,tps65913-pmic > > + ti,tps65914-pmic > > +and also the generic series names > > + ti,palmas-pmic > > + > > +Optional properties: > > +- ti,ldo6-vibrator : ldo6 is in vibrator mode > > + > > +Optional nodes: > > +- regulators : should contain the constrains and init information > for the > > + regulators. It should contain a subnode per regulator from > the > > + list. > > + For ti,palmas-pmic - smps12, smps123, smps3 depending on > OTP, > > + smps45, smps457, smps7 depending on varient, smps6, > smps[8-10], > > + ldo[1-9], ldoln, ldousb > > + > > + optional chip specific regulator fields :- > > + ti,warm-reset - maintain voltage during warm > reset(boolean) > > Pushing the boat out a bit here, but is it possible to reuse > 'regulator-always-on' for this? It is getting used below. > > > + ti,roof-floor - control voltage selection by pin(boolean) > > Is this the same as a GPIO regulator? This is not a GPIO Regulator. > > If so, you might not need to add superfluous vendor specific > properties. > > See: Documentation/devicetree/bindings/regulator/gpio-regulator.txt > > > + ti,sleep-mode - mode to adopt in pmic sleep 0 - off, 1 - > auto, > > + 2 - eco, 3 - forced pwm > > I've seen lots of sleep-mode properties, can't we define a generic one? HW specific modes. > > > + ti,tstep - slope control 0 - Jump, 1 10mV/us, 2 5mV/us, 3 > 2.5mV/us > > + ti,smps-range - OTP has the wrong range set for the > hardware so override > > + 0 - low range, 1 - high range > > + > > +Example: > > + > > +pmic@0 { > > May as well drop the '@0' here unless it's meaningful. Ok. > > > + compatible = "ti,twl6035-pmic", "ti,palmas-pmic"; > > + interrupt-parent = <&palmas>; > > + interrupts = <14 0>; > > Use the defines found in: > > arch/arm/boot/dts/include/dt-bindings/interrupt-controller/irq.h Ok. I will use the defines in the irq.h file. > > > + interrupt-name = "short-irq"; > > + > > + ti,ldo6_vibrator; > > DT doesn't like '_'s, use a '-'s instead. > Oops my bad.. I will change this. > > + regulators { > > + smps12_reg : smps12 { > > + regulator-name = "smps12"; > > + regulator-min-microvolt = < 600000>; > > + regulator-max-microvolt = <1500000>; > > + regulator-always-on; > > + regulator-boot-on; > > + ti,warm-reset; > > Hmm.. I see you're using 'regulator-always-on' and 'ti,warm-reset' > here. Is there every a case where there is one without the other? I am not sure of a case. I see that "warm-reset" property is used Inside the regulator driver. This property is again HW specific And it represents the warm reset sensitivity. If this 1 then voltage Values during warm-reset are maintained if not then default OTP values Are re-loaded during warm-reset. > > > + ti,roof-floor; > > + ti,mode-sleep = <0>; > > + ti,tstep = <0>; > > + ti,smps-range = <1>; > > + }; > > + > > + smps3_reg: smps3 { > > + regulator-name = "smps3"; > > + regulator-min-microvolt = < 600000>; > > + regulator-max-microvolt = <1310000>; > > + }; > > Wow, this is a big example. > > I don't think you need to provide more than 1 or 2 of these _reg nodes. Ok. The intent here was to expose one example with a set of all the regulators And their operating range of voltages. Couple of files already have such examples: Documentation/devicetree/bindings/regulator/tps65090.txt Documentation/devicetree/bindings/regulator/tps65217.txt I can knock off all of them and retain couple of them if this is not needed. > > > + smps45_reg: smps45 { > > + regulator-name = "smps45"; > > + regulator-min-microvolt = < 600000>; > > + regulator-max-microvolt = <1310000>; > > + }; > > + > > + smps6_reg: smps6 { > > + regulator-name = "smps6"; > > + regulator-min-microvolt = <1200000>; > > + regulator-max-microvolt = <1200000>; > > + }; > > + > > + smps7_reg: smps7 { > > + regulator-name = "smps7"; > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <1800000>; > > + }; > > + > > + smps8_reg: smps8 { > > + regulator-name = "smps8"; > > + regulator-min-microvolt = < 600000>; > > + regulator-max-microvolt = <1310000>; > > + }; > > + > > + smps9_reg: smps9 { > > + regulator-name = "smps9"; > > + regulator-min-microvolt = <2100000>; > > + regulator-max-microvolt = <2100000>; > > + }; > > + > > + smps10_reg: smps10 { > > + regulator-name = "smps10"; > > + regulator-min-microvolt = <5000000>; > > + regulator-max-microvolt = <5000000>; > > + }; > > + > > + ldo1_reg: ldo1 { > > + regulator-name = "ldo1"; > > + regulator-min-microvolt = <2800000>; > > + regulator-max-microvolt = <2800000>; > > + }; > > + > > + ldo2_reg: ldo2 { > > + regulator-name = "ldo2"; > > + regulator-min-microvolt = <2900000>; > > + regulator-max-microvolt = <2900000>; > > + }; > > + > > + ldo3_reg: ldo3 { > > + regulator-name = "ldo3"; > > + regulator-min-microvolt = <3000000>; > > + regulator-max-microvolt = <3000000>; > > + }; > > + > > + ldo4_reg: ldo4 { > > + regulator-name = "ldo4"; > > + regulator-min-microvolt = <2200000>; > > + regulator-max-microvolt = <2200000>; > > + }; > > + > > + ldo5_reg: ldo5 { > > + regulator-name = "ldo5"; > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <1800000>; > > + }; > > + > > + ldo6_reg: ldo6 { > > + regulator-name = "ldo6"; > > + regulator-min-microvolt = <1500000>; > > + regulator-max-microvolt = <1500000>; > > + }; > > + > > + ldo7_reg: ldo7 { > > + regulator-name = "ldo7"; > > + regulator-min-microvolt = <1500000>; > > + regulator-max-microvolt = <1500000>; > > + }; > > + > > + ldo8_reg: ldo8 { > > + regulator-name = "ldo8"; > > + regulator-min-microvolt = <1500000>; > > + regulator-max-microvolt = <1500000>; > > + }; > > + > > + ldo9_reg: ldo9 { > > + regulator-name = "ldo9"; > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <1800000>; > > + }; > > + > > + ldoln_reg: ldoln { > > + regulator-name = "ldoln"; > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <1800000>; > > + }; > > + > > + ldousb_reg: ldousb { > > + regulator-name = "ldousb"; > > + regulator-min-microvolt = <3250000>; > > + regulator-max-microvolt = <3250000>; > > + }; > > + }; > > +}; > > -- > Lee Jones > Linaro ST-Ericsson Landing Team Lead > Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook > | Twitter | Blog Regards, Keerthy ^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <20130603141851.GG3370-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH] mfd: DT bindings for the palmas family MFD [not found] ` <20130603141851.GG3370-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> @ 2013-07-10 10:27 ` Mark Brown 0 siblings, 0 replies; 7+ messages in thread From: Mark Brown @ 2013-07-10 10:27 UTC (permalink / raw) To: Lee Jones Cc: mturquette-QSEj5FYQhm4dnm+yROfE0A, sameo-VuQAYsv1563Yd54FQh9/CA, linux-doc-u79uwXL29TY76Z2rM5mHXA, J Keerthy, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ, linux-kernel-u79uwXL29TY76Z2rM5mHXA, rob.herring-bsGFqQB8/DxBDgjK7y7TUQ, lgirdwood-Re5JQEeQqe8AvxtiuMwx3w, t-kristo-l0cyMroinI0, wim-IQzOog9fTRqzQB+pC5nmwQ, gg-kDsPt+C1G03kYMGBc/C6ZA, Ian Lartey [-- Attachment #1.1: Type: text/plain, Size: 1591 bytes --] On Mon, Jun 03, 2013 at 03:18:51PM +0100, Lee Jones wrote: > On Mon, 03 Jun 2013, J Keerthy wrote: > > + optional chip specific regulator fields :- > > + ti,warm-reset - maintain voltage during warm reset(boolean) > Pushing the boat out a bit here, but is it possible to reuse > 'regulator-always-on' for this? This sounds more like "don't reset over reboot" than "never change the enable state". > > + ti,roof-floor - control voltage selection by pin(boolean) > Is this the same as a GPIO regulator? > If so, you might not need to add superfluous vendor specific properties. Lots of regulators have the ability to do things like switch between programmable voltages based on GPIOs (enabling a fast change to a known voltage) - the roof-floor naming sounds like this. Usually there's also register based element for selecting the voltage. > See: Documentation/devicetree/bindings/regulator/gpio-regulator.txt > > + ti,sleep-mode - mode to adopt in pmic sleep 0 - off, 1 - auto, > > + 2 - eco, 3 - forced pwm > I've seen lots of sleep-mode properties, can't we define a generic > one? We should make some of this more standard (at least things like voltages) but the whole concept of what sleep mode is is at best fuzzy. You typically need different selections for suspend to RAM and suspend to disk, plus often the suspend configuration is dynamic depending on what the system is doing since suspend is just CPU suspend not system suspend and there's also some changes that might happen depending on which wake sources are currently available. [-- Attachment #1.2: Digital signature --] [-- Type: application/pgp-signature, Size: 836 bytes --] [-- Attachment #2: Type: text/plain, Size: 192 bytes --] _______________________________________________ devicetree-discuss mailing list devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org https://lists.ozlabs.org/listinfo/devicetree-discuss ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-07-10 10:27 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-03 12:08 [PATCH] mfd: DT bindings for the palmas family MFD J Keerthy
2013-06-03 14:18 ` Lee Jones
2013-06-03 20:38 ` Stephen Warren
2013-06-04 6:24 ` J, KEERTHY
2013-06-04 7:21 ` Lee Jones
2013-06-04 5:28 ` J, KEERTHY
[not found] ` <20130603141851.GG3370-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-07-10 10:27 ` Mark Brown
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).