From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Rohit Vaswani <rvaswani@codeaurora.org>
Cc: Grant Likely <grant.likely@linaro.org>,
Rob Herring <rob.herring@calxeda.com>,
Rob Landley <rob@landley.net>,
David Brown <davidb@codeaurora.org>,
Daniel Walker <dwalker@fifo99.com>,
Bryan Huntsman <bryanh@codeaurora.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org
Subject: Re: [PATCH 2/3] ARM: msm: Re-organize platsmp to make it extensible
Date: Tue, 4 Jun 2013 10:32:58 +0100 [thread overview]
Message-ID: <20130604093258.GS18614@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1370305185-6450-3-git-send-email-rvaswani@codeaurora.org>
On Mon, Jun 03, 2013 at 05:19:44PM -0700, Rohit Vaswani wrote:
> + sc1_base_ptr = of_iomap(dn, 0);
> + if (sc1_base_ptr) {
> + writel_relaxed(0, sc1_base_ptr + VDD_SC1_ARRAY_CLAMP_GFS_CTL);
> + writel_relaxed(0, sc1_base_ptr + SCSS_CPU1CORE_RESET);
> + writel_relaxed(3, sc1_base_ptr + SCSS_DBG_STATUS_CORE_PWRDUP);
> + mb();
> + iounmap(sc1_base_ptr);
If you need to fiddle with power rails and resets for your secondary
core, you don't need any of the pen_release stuff, and you really
should get rid of it. The pen_release stuff is only there for
platforms where there's no proper way of controlling the secondary
CPUs except by using a software method.
next prev parent reply other threads:[~2013-06-04 9:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-04 0:19 [PATCH 0/3] Add SMP support for MSM8660 and MSM8960 Rohit Vaswani
2013-06-04 0:19 ` [PATCH 2/3] ARM: msm: Re-organize platsmp to make it extensible Rohit Vaswani
2013-06-04 9:32 ` Russell King - ARM Linux [this message]
2013-06-04 22:52 ` Rohit Vaswani
2013-06-04 0:19 ` [PATCH 3/3] ARM: msm: Add SMP support for 8960 Rohit Vaswani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130604093258.GS18614@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=bryanh@codeaurora.org \
--cc=davidb@codeaurora.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dwalker@fifo99.com \
--cc=grant.likely@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=rvaswani@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).