Re: DT version of kirkwood_ge0x_init()

From: Simon Guinot <simon.guinot@sequanux.org>
To: Jason Cooper <jason@lakedaemon.net>
Cc: Andrew Lunn <andrew@lunn.ch>,
	"Longchamp, Valentin" <Valentin.Longchamp@keymile.com>,
	devicetree-discuss@lists.ozlabs.org, "Brunck,
	Holger" <Holger.Brunck@keymile.com>,
	Gerlando Falauto <gerlando.falauto@keymile.com>,
	Simon Guinot <simon@sequanux.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: DT version of kirkwood_ge0x_init()
Date: Tue, 4 Jun 2013 13:59:27 +0200	[thread overview]
Message-ID: <20130604115927.GJ7626@kw.sim.vm.gnt> (raw)
In-Reply-To: <20130604104302.GX3803@titan.lakedaemon.net>

[-- Attachment #1.1: Type: text/plain, Size: 2455 bytes --]

On Tue, Jun 04, 2013 at 06:43:02AM -0400, Jason Cooper wrote:
> On Tue, Jun 04, 2013 at 12:34:42PM +0200, Sebastian Hesselbarth wrote:
> > On 06/04/13 12:18, Gerlando Falauto wrote:
> > >I noticed how most of the DT-aware board-setup files only have a single
> > ><board>_init() function, calling kirkwood_ge00_init() with a struct
> > >mv643xx_eth_platform_data as a single argument.
> > >
> > >I was wondering -- is there a reason why we cannot remove all this
> > >board-specific code and move all this to the DT?
> > 
> > Gerlando,
> > 
> > DT for mv643xx_eth is on the way (https://lkml.org/lkml/2013/5/29/527).
> > We wait for the driver to surface to relax branch dependencies and then
> > move all DT Orion SoCs to it.
> > 
> > > I would really love to have all our boards under a single
> > > CONFIG_<FAMILY>_DT and a single compatible string, with all the
> > > differences within the DTs itself -- no more #ifdef CONFIG_<BOARD>,
> > > no more of_machine_is_compatible("boardXXX").
> > 
> > All those will happen if there is DT support for mv643xx_eth which
> > is the only driver left without DT and board dependencies. But there
> > will be no CONFIG_LACIE_DT or whatever, but just CONFIG_KIRKWOOD_DT
> > and board dependent stuff described in the corresponding dts.
> 
> Gerlando,
> 
> Yes, the mess you describe is temporary.  Those board files used to have
> a lot more code in them, legacy init of partitions, MPP, LEDs, etc.  As
> we have converted drivers, they have gotten smaller and smaller.
> 
> Now, with Sebastian's hard work, we'll finally be able to remove them
> and kirkwood will be completely DT.  We're very excited about this. :)
> 
> Next, we'll move the Marvell DT boards over to mach-mvebu/ and only
> legacy boards in -kirkwood/, -orion5x/, -dove/, and -mv78xx0/ will
> remain.  After a few releases we will deprecate any legacy boards which
> haven't been converted to DT.

Hi Jason,

While I have obviously planed to convert all the LaCie boards to DT,
I think that removing the legacy support so quickly is a little bit
harsh.

IMHO, it could be nice to wait the end-of-life for all this products
before removing their support.

Regards,

Simon

> 
> thx,
> 
> Jason.
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel