From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 1/3] pinctrl: pinctrl-single: enhance to configure multiple pins of different modules Date: Wed, 5 Jun 2013 15:01:39 -0700 Message-ID: <20130605220138.GE3331@atomide.com> References: <1369145282-14419-1-git-send-email-prakash.pm@ti.com> <1369145282-14419-3-git-send-email-prakash.pm@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1369145282-14419-3-git-send-email-prakash.pm@ti.com> Sender: linux-kernel-owner@vger.kernel.org To: "Manjunathappa, Prakash" Cc: linus.walleij@linaro.org, nsekhar@ti.com, grant.likely@linaro.org, rob.herring@calxeda.com, linux@arm.linux.org.uk, rob@landley.net, prabhakar.csengg@gmail.com, peter.ujfalusi@ti.com, devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, davinci-linux-open-source@linux.davincidsp.com List-Id: devicetree@vger.kernel.org * Manjunathappa, Prakash [130521 07:13]: > Add support to configure multiple pins in each register, existing > implementation added by [1] does not support full fledge multiple pin > configuration in single register, reports a pin clash when different > modules configure different bits of same register. The issue reported > and discussed here > http://www.spinics.net/lists/arm-kernel/msg235213.html > > With pinctrl-single,bits-per-mux property specified, use function-mask > property to find out number pins to configure. Allocate and register > pin control functions based sub mask. Thanks for fixing this! Looks good to me, and things keep working for me just fine with these applied: Acked-by: Tony Lindgren