Re: [PATCH 4/4] ARM i.MX53: tqma53: add WP/CD pinctrl and vmmc to esdhc2

[Steffen Trumtrar <s.trumtrar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>]

On Thu, Jun 06, 2013 at 04:55:51PM +0800, Shawn Guo wrote:
> On Tue, Jun 04, 2013 at 11:12:30AM +0200, Steffen Trumtrar wrote:
> > Add WP/CD pinctrl for esdhc2.
> > Also, add vmmc-supply for esdhc2.
> > 
> > Signed-off-by: Steffen Trumtrar <s.trumtrar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> > ---
> >  arch/arm/boot/dts/imx53-tqma53.dtsi | 13 ++++++++++++-
> >  1 file changed, 12 insertions(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/boot/dts/imx53-tqma53.dtsi b/arch/arm/boot/dts/imx53-tqma53.dtsi
> > index 450e4de..9ecd198 100644
> > --- a/arch/arm/boot/dts/imx53-tqma53.dtsi
> > +++ b/arch/arm/boot/dts/imx53-tqma53.dtsi
> > @@ -35,7 +35,9 @@
> >  
> >  &esdhc2 {
> >  	pinctrl-names = "default";
> > -	pinctrl-0 = <&pinctrl_esdhc2_1>;
> > +	pinctrl-0 = <&pinctrl_esdhc2_1>,
> > +		    <&pinctrl_esdhc2_2>;
> > +	vmmc-supply = <&reg_3p3v>;
> >  	wp-gpios = <&gpio1 2 0>;
> >  	cd-gpios = <&gpio1 4 0>;
> >  	status = "disabled";
> > @@ -69,6 +71,15 @@
> >  	pinctrl-names = "default";
> >  	pinctrl-0 = <&pinctrl_hog>;
> >  
> > +	esdhc2_2 {
> > +		pinctrl_esdhc2_2: esdhc2-grp2 {
> 
> pinctrl_esdhc2_2 should be used by <soc>.dtsi to define the second pin
> group for esdhc2 function, so please encode the board name in it to
> avoid the name space conflict. 
> 

Hi!

Okay. I will fix that and resend.

Thanks,
Steffen

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |