[patch -next] spi: spi-xilinx: cleanup a check in xilinx_spi_txrx_bufs()

[patch -next] spi: spi-xilinx: cleanup a check in xilinx_spi_txrx_bufs()

[Dan Carpenter, Peter Crosthwaite]

'!' has higher precedence than comparisons so the original condition
is equivalent to "if (xspi->remaining_bytes == 0)".  This makes the
static checkers complain.

xspi->remaining_bytes is signed and from looking at the code
briefly, I think it might be able to go negative.  I suspect that
going negative may cause a bug, but I don't have the hardware and
can't test.

Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>

diff --git a/drivers/spi/spi-xilinx.c b/drivers/spi/spi-xilinx.c
index 0b8398c..fb56fcf 100644
--- a/drivers/spi/spi-xilinx.c
+++ b/drivers/spi/spi-xilinx.c
@@ -301,7 +301,7 @@ static int xilinx_spi_txrx_bufs(struct spi_device *spi, struct spi_transfer *t)
 		}
 
 		/* See if there is more data to send */
-		if (!xspi->remaining_bytes > 0)
+		if (xspi->remaining_bytes <= 0)
 			break;
 	}

Re: [patch -next] spi: spi-xilinx: cleanup a check in xilinx_spi_txrx_bufs()

[Mark Brown]

[-- Attachment #1.1: Type: text/plain, Size: 250 bytes --]

On Sun, Jun 09, 2013 at 04:07:28PM +0300, Dan Carpenter wrote:
> '!' has higher precedence than comparisons so the original condition
> is equivalent to "if (xspi->remaining_bytes == 0)".  This makes the
> static checkers complain.

Applied, thanks.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 192 bytes --]

_______________________________________________
devicetree-discuss mailing list
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
https://lists.ozlabs.org/listinfo/devicetree-discuss