[PATCH v3] mfd: DT bindings for the palmas family MFD

[PATCH v3] mfd: DT bindings for the palmas family MFD

[J Keerthy]

Add the various binding files for the palmas family of chips. There is a
top level MFD binding then a seperate binding for regulators IP blocks on chips.

Signed-off-by: Graeme Gregory <gg@slimlogic.co.uk>
Signed-off-by: J Keerthy <j-keerthy@ti.com>
Signed-off-by: Ian Lartey <ian@slimlogic.co.uk>
Reviewed-by: Stephen Warren <swarren@nvidia.com> 
---
 Documentation/devicetree/bindings/mfd/palmas.txt   |   49 +++++++++++++
 .../devicetree/bindings/regulator/palmas-pmic.txt  |   72 ++++++++++++++++++++
 2 files changed, 121 insertions(+), 0 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/mfd/palmas.txt
 create mode 100644 Documentation/devicetree/bindings/regulator/palmas-pmic.txt

diff --git a/Documentation/devicetree/bindings/mfd/palmas.txt b/Documentation/devicetree/bindings/mfd/palmas.txt
new file mode 100644
index 0000000..7bcd59c
--- /dev/null
+++ b/Documentation/devicetree/bindings/mfd/palmas.txt
@@ -0,0 +1,49 @@
+* palmas device tree bindings
+
+The TI palmas family current members :-
+twl6035 (palmas)
+twl6037 (palmas)
+tps65913 (palmas)
+tps65914 (palmas)
+
+Required properties:
+- compatible : Should be from the list
+  ti,twl6035
+  ti,twl6036
+  ti,twl6037
+  ti,tps65913
+  ti,tps65914
+  ti,tps80036
+and also the generic series names
+  ti,palmas
+- interrupt-controller : palmas has its own internal IRQs
+- #interrupt-cells : should be set to 2 for IRQ number and flags
+  The first cell is the IRQ number.
+  The second cell is the flags, encoded as the trigger masks from
+  Documentation/devicetree/bindings/interrupts.txt
+- interrupt-parent : The parent interrupt controller.
+
+Optional properties:
+  ti,mux-padX : set the pad register X (1-2) to the correct muxing for the
+  		hardware, if not set will use muxing in OTP.
+
+Example:
+
+palmas {
+	compatible = "ti,twl6035", "ti,palmas";
+	reg = <0x48>
+	interrupt-parent = <&intc>;
+	interrupt-controller;
+	#interrupt-cells = <2>;
+
+	ti,mux-pad1 = <0>;
+	ti,mux-pad2 = <0>;
+
+	#address-cells = <1>;
+	#size-cells = <0>;
+
+	pmic {
+		compatible = "ti,twl6035-pmic", "ti,palmas-pmic";
+		....
+	};
+}
diff --git a/Documentation/devicetree/bindings/regulator/palmas-pmic.txt b/Documentation/devicetree/bindings/regulator/palmas-pmic.txt
new file mode 100644
index 0000000..d5a3086
--- /dev/null
+++ b/Documentation/devicetree/bindings/regulator/palmas-pmic.txt
@@ -0,0 +1,72 @@
+* palmas regulator IP block devicetree bindings
+
+Required properties:
+- compatible : Should be from the list
+  ti,twl6035-pmic
+  ti,twl6036-pmic
+  ti,twl6037-pmic
+  ti,tps65913-pmic
+  ti,tps65914-pmic
+and also the generic series names
+  ti,palmas-pmic
+- interrupt-parent : The parent interrupt controller which is palmas.
+- interrupts : The interrupt number and the type which can be looked up here:
+	       arch/arm/boot/dts/include/dt-bindings/interrupt-controller/irq.h
+- interrupts-name: The names of the individual interrupts.
+
+Optional properties:
+- ti,ldo6-vibrator : ldo6 is in vibrator mode
+
+Optional nodes:
+- regulators : Must contain a sub-node per regulator from the list below.
+	       Each sub-node should contain the constraints and initialization
+	       information for that regulator. See regulator.txt for a
+	       description of standard properties for these sub-nodes.
+	       Additional custom properties  are listed below.
+
+	       For ti,palmas-pmic - smps12, smps123, smps3 depending on OTP,
+	       smps45, smps457, smps7 depending on variant, smps6, smps[8-10],
+	       ldo[1-9], ldoln, ldousb.
+
+	       Optional sub-node properties:
+	       ti,warm-reset - maintain voltage during warm reset(boolean)
+	       ti,roof-floor - control voltage selection by pin(boolean)
+	       ti,sleep-mode - mode to adopt in pmic sleep 0 - off, 1 - auto,
+	       2 - eco, 3 - forced pwm
+	       ti,tstep - slope control 0 - Jump, 1 10mV/us, 2 5mV/us, 3 2.5mV/us
+	       ti,smps-range - OTP has the wrong range set for the hardware so override
+	       0 - low range, 1 - high range.
+
+Example:
+
+#include <dt-bindings/interrupt-controller/irq.h>
+
+pmic {
+	compatible = "ti,twl6035-pmic", "ti,palmas-pmic";
+	interrupt-parent = <&palmas>;
+	interrupts = <14 IRQ_TYPE_NONE>;
+	interrupts-name = "short-irq";
+
+	ti,ldo6-vibrator;
+
+	regulators {
+		smps12_reg : smps12 {
+			regulator-name = "smps12";
+			regulator-min-microvolt = < 600000>;
+			regulator-max-microvolt = <1500000>;
+			regulator-always-on;
+			regulator-boot-on;
+			ti,warm-reset;
+			ti,roof-floor;
+			ti,mode-sleep = <0>;
+			ti,tstep = <0>;
+			ti,smps-range = <1>;
+		};
+
+		ldo1_reg: ldo1 {
+			regulator-name = "ldo1";
+			regulator-min-microvolt = <2800000>;
+			regulator-max-microvolt = <2800000>;
+		};
+	};
+};
-- 
1.7.5.4

Re: [PATCH v3] mfd: DT bindings for the palmas family MFD

[Lee Jones]

On Thu, 06 Jun 2013, J Keerthy wrote:

> Add the various binding files for the palmas family of chips. There is a
> top level MFD binding then a seperate binding for regulators IP blocks on chips.
> 
> Signed-off-by: Graeme Gregory <gg@slimlogic.co.uk>
> Signed-off-by: J Keerthy <j-keerthy@ti.com>
> Signed-off-by: Ian Lartey <ian@slimlogic.co.uk>
> Reviewed-by: Stephen Warren <swarren@nvidia.com> 
> ---
>  Documentation/devicetree/bindings/mfd/palmas.txt   |   49 +++++++++++++
>  .../devicetree/bindings/regulator/palmas-pmic.txt  |   72 ++++++++++++++++++++
>  2 files changed, 121 insertions(+), 0 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/mfd/palmas.txt
>  create mode 100644
> Documentation/devicetree/bindings/regulator/palmas-pmic.tx

Applied, thanks.

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH v3] mfd: DT bindings for the palmas family MFD

[Lee Jones]

On Thu, 06 Jun 2013, Lee Jones wrote:

> On Thu, 06 Jun 2013, J Keerthy wrote:
> 
> > Add the various binding files for the palmas family of chips. There is a
> > top level MFD binding then a seperate binding for regulators IP blocks on chips.
> > 
> > Signed-off-by: Graeme Gregory <gg@slimlogic.co.uk>
> > Signed-off-by: J Keerthy <j-keerthy@ti.com>
> > Signed-off-by: Ian Lartey <ian@slimlogic.co.uk>
> > Reviewed-by: Stephen Warren <swarren@nvidia.com> 
> > ---
> >  Documentation/devicetree/bindings/mfd/palmas.txt   |   49 +++++++++++++
> >  .../devicetree/bindings/regulator/palmas-pmic.txt  |   72 ++++++++++++++++++++
> >  2 files changed, 121 insertions(+), 0 deletions(-)
> >  create mode 100644 Documentation/devicetree/bindings/mfd/palmas.txt
> >  create mode 100644
> > Documentation/devicetree/bindings/regulator/palmas-pmic.tx
> 
> Applied, thanks.

Ah wait. It appears Grant wants to take this.

Unapplied, thanks. :)

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

RE: [PATCH v3] mfd: DT bindings for the palmas family MFD

[J, KEERTHY]

________________________________________
From: Lee Jones [lee.jones@linaro.org]
Sent: Thursday, June 06, 2013 12:36 PM
To: J, KEERTHY
Cc: linux-kernel@vger.kernel.org; grant.likely@secretlab.ca; linux-doc@vger.kernel.org; devicetree-discuss@lists.ozlabs.org; swarren@wwwdotorg.org; swarren@nvidia.com; rob.herring@calxeda.com; rob@landley.net; sameo@linux.intel.com; wim@iguana.be; lgirdwood@gmail.com; gg@slimlogic.co.uk; Kristo, Tero; Ian Lartey
Subject: Re: [PATCH v3] mfd: DT bindings for the palmas family MFD

On Thu, 06 Jun 2013, Lee Jones wrote:

> On Thu, 06 Jun 2013, J Keerthy wrote:
>
> > Add the various binding files for the palmas family of chips. There is a
> > top level MFD binding then a seperate binding for regulators IP blocks on chips.
> >
> > Signed-off-by: Graeme Gregory <gg@slimlogic.co.uk>
> > Signed-off-by: J Keerthy <j-keerthy@ti.com>
> > Signed-off-by: Ian Lartey <ian@slimlogic.co.uk>
> > Reviewed-by: Stephen Warren <swarren@nvidia.com>
> > ---
> >  Documentation/devicetree/bindings/mfd/palmas.txt   |   49 +++++++++++++
> >  .../devicetree/bindings/regulator/palmas-pmic.txt  |   72 ++++++++++++++++++++
> >  2 files changed, 121 insertions(+), 0 deletions(-)
> >  create mode 100644 Documentation/devicetree/bindings/mfd/palmas.txt
> >  create mode 100644
> > Documentation/devicetree/bindings/regulator/palmas-pmic.tx
>
> Applied, thanks.

Grant,

Could you pull this and drop the v2 of this patch please?

Regards,
Keerthy


Ah wait. It appears Grant wants to take this.

Unapplied, thanks. :)

--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

RE: [PATCH v3] mfd: DT bindings for the palmas family MFD

[J, KEERTHY]

Hello Grant/Lee Jones,

> -----Original Message-----
> From: Lee Jones [mailto:lee.jones@linaro.org]
> Sent: Thursday, June 06, 2013 12:36 PM
> To: J, KEERTHY
> Cc: linux-kernel@vger.kernel.org; grant.likely@secretlab.ca; linux-
> doc@vger.kernel.org; devicetree-discuss@lists.ozlabs.org;
> swarren@wwwdotorg.org; swarren@nvidia.com; rob.herring@calxeda.com;
> rob@landley.net; sameo@linux.intel.com; wim@iguana.be;
> lgirdwood@gmail.com; gg@slimlogic.co.uk; Kristo, Tero; Ian Lartey
> Subject: Re: [PATCH v3] mfd: DT bindings for the palmas family MFD
> 
> On Thu, 06 Jun 2013, Lee Jones wrote:
> 
> > On Thu, 06 Jun 2013, J Keerthy wrote:
> >
> > > Add the various binding files for the palmas family of chips. There
> > > is a top level MFD binding then a seperate binding for regulators
> IP blocks on chips.
> > >
> > > Signed-off-by: Graeme Gregory <gg@slimlogic.co.uk>
> > > Signed-off-by: J Keerthy <j-keerthy@ti.com>
> > > Signed-off-by: Ian Lartey <ian@slimlogic.co.uk>
> > > Reviewed-by: Stephen Warren <swarren@nvidia.com>
> > > ---
> > >  Documentation/devicetree/bindings/mfd/palmas.txt   |   49
> +++++++++++++
> > >  .../devicetree/bindings/regulator/palmas-pmic.txt  |   72
> ++++++++++++++++++++
> > >  2 files changed, 121 insertions(+), 0 deletions(-)  create mode
> > > 100644 Documentation/devicetree/bindings/mfd/palmas.txt
> > >  create mode 100644
> > > Documentation/devicetree/bindings/regulator/palmas-pmic.tx
> >
> > Applied, thanks.
> 
> Ah wait. It appears Grant wants to take this.
> 
> Unapplied, thanks. :)
> 

Is it applied?

> --
> Lee Jones
> Linaro ST-Ericsson Landing Team Lead
> Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook
> | Twitter | Blog

Thanks,
Keerthy

Re: [PATCH v3] mfd: DT bindings for the palmas family MFD

[Lee Jones]

On Mon, 10 Jun 2013, J, KEERTHY wrote:

> Hello Grant/Lee Jones,
> 
> > -----Original Message-----
> > From: Lee Jones [mailto:lee.jones@linaro.org]
> > Sent: Thursday, June 06, 2013 12:36 PM
> > To: J, KEERTHY
> > Cc: linux-kernel@vger.kernel.org; grant.likely@secretlab.ca; linux-
> > doc@vger.kernel.org; devicetree-discuss@lists.ozlabs.org;
> > swarren@wwwdotorg.org; swarren@nvidia.com; rob.herring@calxeda.com;
> > rob@landley.net; sameo@linux.intel.com; wim@iguana.be;
> > lgirdwood@gmail.com; gg@slimlogic.co.uk; Kristo, Tero; Ian Lartey
> > Subject: Re: [PATCH v3] mfd: DT bindings for the palmas family MFD
> > 
> > On Thu, 06 Jun 2013, Lee Jones wrote:
> > 
> > > On Thu, 06 Jun 2013, J Keerthy wrote:
> > >
> > > > Add the various binding files for the palmas family of chips. There
> > > > is a top level MFD binding then a seperate binding for regulators
> > IP blocks on chips.
> > > >
> > > > Signed-off-by: Graeme Gregory <gg@slimlogic.co.uk>
> > > > Signed-off-by: J Keerthy <j-keerthy@ti.com>
> > > > Signed-off-by: Ian Lartey <ian@slimlogic.co.uk>
> > > > Reviewed-by: Stephen Warren <swarren@nvidia.com>
> > > > ---
> > > >  Documentation/devicetree/bindings/mfd/palmas.txt   |   49
> > +++++++++++++
> > > >  .../devicetree/bindings/regulator/palmas-pmic.txt  |   72
> > ++++++++++++++++++++
> > > >  2 files changed, 121 insertions(+), 0 deletions(-)  create mode
> > > > 100644 Documentation/devicetree/bindings/mfd/palmas.txt
> > > >  create mode 100644
> > > > Documentation/devicetree/bindings/regulator/palmas-pmic.tx
> > >
> > > Applied, thanks.
> > 
> > Ah wait. It appears Grant wants to take this.
> > 
> > Unapplied, thanks. :)
> > 
> 
> Is it applied?

Not by me. I unapplied it when I saw that Grant took an earlier
revision.

I won't apply again unless Grant gives the nod. Failing that, I'm sure
he'll take it.

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

RE: [PATCH v3] mfd: DT bindings for the palmas family MFD

[J, KEERTHY]

Hello Grant,

> -----Original Message-----
> From: Lee Jones [mailto:lee.jones@linaro.org]
> Sent: Monday, June 10, 2013 3:25 PM
> To: J, KEERTHY
> Cc: grant.likely@secretlab.ca; linux-kernel@vger.kernel.org; linux-
> doc@vger.kernel.org; devicetree-discuss@lists.ozlabs.org;
> swarren@wwwdotorg.org; swarren@nvidia.com; rob.herring@calxeda.com;
> rob@landley.net; sameo@linux.intel.com; wim@iguana.be;
> lgirdwood@gmail.com; gg@slimlogic.co.uk; Kristo, Tero; Ian Lartey
> Subject: Re: [PATCH v3] mfd: DT bindings for the palmas family MFD
> 
> On Mon, 10 Jun 2013, J, KEERTHY wrote:
> 
> > Hello Grant/Lee Jones,
> >
> > > -----Original Message-----
> > > From: Lee Jones [mailto:lee.jones@linaro.org]
> > > Sent: Thursday, June 06, 2013 12:36 PM
> > > To: J, KEERTHY
> > > Cc: linux-kernel@vger.kernel.org; grant.likely@secretlab.ca; linux-
> > > doc@vger.kernel.org; devicetree-discuss@lists.ozlabs.org;
> > > swarren@wwwdotorg.org; swarren@nvidia.com; rob.herring@calxeda.com;
> > > rob@landley.net; sameo@linux.intel.com; wim@iguana.be;
> > > lgirdwood@gmail.com; gg@slimlogic.co.uk; Kristo, Tero; Ian Lartey
> > > Subject: Re: [PATCH v3] mfd: DT bindings for the palmas family MFD
> > >
> > > On Thu, 06 Jun 2013, Lee Jones wrote:
> > >
> > > > On Thu, 06 Jun 2013, J Keerthy wrote:
> > > >
> > > > > Add the various binding files for the palmas family of chips.
> > > > > There is a top level MFD binding then a seperate binding for
> > > > > regulators
> > > IP blocks on chips.
> > > > >
> > > > > Signed-off-by: Graeme Gregory <gg@slimlogic.co.uk>
> > > > > Signed-off-by: J Keerthy <j-keerthy@ti.com>
> > > > > Signed-off-by: Ian Lartey <ian@slimlogic.co.uk>
> > > > > Reviewed-by: Stephen Warren <swarren@nvidia.com>
> > > > > ---
> > > > >  Documentation/devicetree/bindings/mfd/palmas.txt   |   49
> > > +++++++++++++
> > > > >  .../devicetree/bindings/regulator/palmas-pmic.txt  |   72
> > > ++++++++++++++++++++
> > > > >  2 files changed, 121 insertions(+), 0 deletions(-)  create
> mode
> > > > > 100644 Documentation/devicetree/bindings/mfd/palmas.txt
> > > > >  create mode 100644
> > > > > Documentation/devicetree/bindings/regulator/palmas-pmic.tx
> > > >
> > > > Applied, thanks.
> > >
> > > Ah wait. It appears Grant wants to take this.
> > >
> > > Unapplied, thanks. :)
> > >
> >
> > Is it applied?
> 
> Not by me. I unapplied it when I saw that Grant took an earlier
> revision.
> 
> I won't apply again unless Grant gives the nod. Failing that, I'm sure
> he'll take it.

There were outstanding comments for v2 of this patch.
I think you applied v2 of this patch.
Could you annul v2 and please apply v3 of the patch?

> 
> --
> Lee Jones
> Linaro ST-Ericsson Landing Team Lead
> Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook
> | Twitter | Blog

Kind Regards,
Keerthy

RE: [PATCH v3] mfd: DT bindings for the palmas family MFD

[Grant Likely]

On Wed, 12 Jun 2013 08:24:26 +0000, "J, KEERTHY" <j-keerthy@ti.com> wrote:
> Hello Grant,
> 
> > -----Original Message-----
> > From: Lee Jones [mailto:lee.jones@linaro.org]
> > > > >
> > > > > Applied, thanks.
> > > >
> > > > Ah wait. It appears Grant wants to take this.
> > > >
> > > > Unapplied, thanks. :)
> > > >
> > >
> > > Is it applied?
> > 
> > Not by me. I unapplied it when I saw that Grant took an earlier
> > revision.
> > 
> > I won't apply again unless Grant gives the nod. Failing that, I'm sure
> > he'll take it.
> 
> There were outstanding comments for v2 of this patch.
> I think you applied v2 of this patch.
> Could you annul v2 and please apply v3 of the patch?

Done

g.

RE: [PATCH v3] mfd: DT bindings for the palmas family MFD

[J, KEERTHY]

> -----Original Message-----
> From: Grant Likely [mailto:glikely@secretlab.ca] On Behalf Of Grant
> Likely
> Sent: Wednesday, June 12, 2013 2:59 PM
> To: J, KEERTHY
> Cc: linux-kernel@vger.kernel.org; linux-doc@vger.kernel.org;
> devicetree-discuss@lists.ozlabs.org; swarren@wwwdotorg.org;
> swarren@nvidia.com; rob.herring@calxeda.com; rob@landley.net;
> sameo@linux.intel.com; wim@iguana.be; lgirdwood@gmail.com;
> gg@slimlogic.co.uk; Kristo, Tero; Ian Lartey; Lee Jones
> Subject: RE: [PATCH v3] mfd: DT bindings for the palmas family MFD
> 
> On Wed, 12 Jun 2013 08:24:26 +0000, "J, KEERTHY" <j-keerthy@ti.com>
> wrote:
> > Hello Grant,
> >
> > > -----Original Message-----
> > > From: Lee Jones [mailto:lee.jones@linaro.org]
> > > > > >
> > > > > > Applied, thanks.
> > > > >
> > > > > Ah wait. It appears Grant wants to take this.
> > > > >
> > > > > Unapplied, thanks. :)
> > > > >
> > > >
> > > > Is it applied?
> > >
> > > Not by me. I unapplied it when I saw that Grant took an earlier
> > > revision.
> > >
> > > I won't apply again unless Grant gives the nod. Failing that, I'm
> > > sure he'll take it.
> >
> > There were outstanding comments for v2 of this patch.
> > I think you applied v2 of this patch.
> > Could you annul v2 and please apply v3 of the patch?
> 
> Done
> 
> g.

Thanks Grant.

Regards,
Keerthy