devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: "Quadros, Roger" <rogerq@ti.com>
Cc: "linus.walleij@linaro.org" <linus.walleij@linaro.org>,
	"devicetree-discuss@lists.ozlabs.org"
	<devicetree-discuss@lists.ozlabs.org>,
	Haojian Zhuang <haojian.zhuang@gmail.com>,
	"Ujfalusi, Peter" <peter.ujfalusi@ti.com>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 4/4] ARM: OMAP: Move DT wake-up event handling over to use pinctrl-single-omap
Date: Mon, 10 Jun 2013 07:25:11 -0700	[thread overview]
Message-ID: <20130610142511.GF8164@atomide.com> (raw)
In-Reply-To: <688FBEF7C8277944BE5AED9A41FB1EBC1AB12DA0@DNCE05.ent.ti.com>

* Quadros, Roger <rogerq@ti.com> [130610 05:37]:
> Hi Tony, (sorry, on Outlook web)
> 
> -                       compatible = "ti,omap4-padconf", "pinctrl-single";
> +                       compatible = "ti,omap4-padconf";
> 
> This change is not necessary if we make sure the pinctrl-single-omap driver
> gets registered early enough, before the pinctrl devices are probed.
>  (e.g. subsys_initcall())

I'd rather make everything just module_init, there should not be
any need to tinker with the init call ordering any longer with
deferred probe. And by making everything into regular device drivers
we actually see real error messages without DEBUG_LL and earlyprintk
if something goes wrong.

Note that there are patches queued to make twl-core.c just regular
module_init as well, so that should fix any issues you might be
related it probing before pinctrl.
 
> I've commented about this in the other patch.

Sorry can you clarify, which other patch? The other message I saw
in this thread was empty. Or at least I have not seen it yet.

Regards,

Tony

  reply	other threads:[~2013-06-10 14:25 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20130607203936.16513.57494.stgit@localhost>
2013-06-07 20:50 ` [PATCH 1/4] pinctrl: single: Prepare for supporting SoC specific features Tony Lindgren
2013-06-08  9:37   ` Haojian Zhuang
2013-06-08 15:27     ` Tony Lindgren
2013-06-09  5:21       ` Haojian Zhuang
2013-07-22 21:15       ` Linus Walleij
2013-07-29  8:57         ` Tony Lindgren
2013-06-07 20:50 ` [PATCH 2/4] pinctrl: single: Add hardware specific hooks for IRQ and GPIO wake-up events Tony Lindgren
2013-06-09  4:46   ` Haojian Zhuang
2013-06-10 15:36     ` Tony Lindgren
2013-07-22 21:44       ` Linus Walleij
2013-07-29  8:50         ` Tony Lindgren
2013-06-07 20:50 ` [PATCH 3/4] pinctrl: single: omap: Add SoC specific module for " Tony Lindgren
2013-06-08 15:29   ` Tony Lindgren
2013-06-09  5:28   ` Haojian Zhuang
2013-06-10 10:03   ` Quadros, Roger
2013-06-10 15:21     ` Tony Lindgren
2013-06-11 12:51       ` Roger Quadros
2013-06-12 13:33         ` Tony Lindgren
2013-07-22 22:03   ` Linus Walleij
2013-07-22 22:06   ` Linus Walleij
2013-06-07 20:50 ` [PATCH 4/4] ARM: OMAP: Move DT wake-up event handling over to use pinctrl-single-omap Tony Lindgren
2013-06-07 20:52   ` Tony Lindgren
2013-06-10 15:36     ` Tony Lindgren
2013-06-10 12:31   ` Quadros, Roger
2013-06-10 14:25     ` Tony Lindgren [this message]
2013-06-11  9:08       ` Roger Quadros

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130610142511.GF8164@atomide.com \
    --to=tony@atomide.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=haojian.zhuang@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=peter.ujfalusi@ti.com \
    --cc=rogerq@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).