From mboxrd@z Thu Jan 1 00:00:00 1970 From: Will Deacon Subject: Re: [PATCH 4/9] ARM: dma-mapping: NULLify dev->archdata.mapping pointer on detach Date: Tue, 11 Jun 2013 09:50:15 +0100 Message-ID: <20130611085015.GC24729@mudshark.cambridge.arm.com> References: <1370889285-22799-1-git-send-email-will.deacon@arm.com> <1370889285-22799-5-git-send-email-will.deacon@arm.com> <20130611.083455.1500863288897785600.hdoyu@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20130611.083455.1500863288897785600.hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Hiroshi Doyu Cc: "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org" , "devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: devicetree@vger.kernel.org On Tue, Jun 11, 2013 at 06:34:55AM +0100, Hiroshi Doyu wrote: > Hi Will, > > Will Deacon wrote @ Mon, 10 Jun 2013 20:34:40 +0200: > > > The current code only clobbers a local variable, so the device is left > > with a stale mapping pointer. > > True. This's my bad. Thanks. That's alright, it's easy to fix. Mind if I add your ack please? Will