From: Thierry Reding <thierry.reding@gmail.com>
To: Steffen Trumtrar <s.trumtrar@pengutronix.de>
Cc: linux-kernel@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org, kernel@pengutronix.de
Subject: Re: [PATCH v3] pwm: add pca9685 driver
Date: Wed, 12 Jun 2013 13:30:30 +0200 [thread overview]
Message-ID: <20130612113029.GC1940@manwe> (raw)
In-Reply-To: <20130606080300.GG21522@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 1404 bytes --]
On Thu, Jun 06, 2013 at 10:03:00AM +0200, Steffen Trumtrar wrote:
> On Thu, May 30, 2013 at 09:50:12AM +0200, Steffen Trumtrar wrote:
> > Add pwm driver for the NXP pca9685 16 channel pwm-led controller.
> >
> > The driver is really barebones at this stage. E.g. the OE' pin and
> > therefore the corresponding registers are not supported.
> > The driver was tested on a HW where this pin is tied to GND.
> >
> > Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> > ---
> > Changes since v2:
> > - s/pwm-pca9685-led/pwm-pca9685/g
> > - replace DT properties with booleans
> > - whitespace/blank line cleanup
> > - add "depends on REGMAP_I2C" in Kconfig
> > - rework code readability
> > - add pwm_ops.free function
> > - set SLEEP bit on request/free/remove
> >
> > Changes since v1:
> > - fix typo in documentation example
> >
> > .../devicetree/bindings/pwm/nxp,pca9685-pwm.txt | 27 ++
> > drivers/pwm/Kconfig | 9 +
> > drivers/pwm/Makefile | 1 +
> > drivers/pwm/pwm-pca9685.c | 291 +++++++++++++++++++++
> > 4 files changed, 328 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/pwm/nxp,pca9685-pwm.txt
> > create mode 100644 drivers/pwm/pwm-pca9685.c
> >
>
> Ping ?!
Applied with some small fixups, thanks.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-06-12 11:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-30 7:50 [PATCH v3] pwm: add pca9685 driver Steffen Trumtrar
[not found] ` <1369900212-14368-1-git-send-email-s.trumtrar-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-06-06 8:03 ` Steffen Trumtrar
2013-06-12 11:30 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130612113029.GC1940@manwe \
--to=thierry.reding@gmail.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=s.trumtrar@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).