devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Roger Quadros <rogerq@ti.com>
Cc: "linus.walleij@linaro.org" <linus.walleij@linaro.org>,
	"devicetree-discuss@lists.ozlabs.org"
	<devicetree-discuss@lists.ozlabs.org>,
	Haojian Zhuang <haojian.zhuang@gmail.com>,
	"Ujfalusi, Peter" <peter.ujfalusi@ti.com>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 3/4] pinctrl: single: omap: Add SoC specific module for wake-up events
Date: Wed, 12 Jun 2013 06:33:06 -0700	[thread overview]
Message-ID: <20130612133306.GR8164@atomide.com> (raw)
In-Reply-To: <51B71D39.6080202@ti.com>

* Roger Quadros <rogerq@ti.com> [130611 05:57]:
> On 06/10/2013 06:21 PM, Tony Lindgren wrote:
> > * Quadros, Roger <rogerq@ti.com> [130610 03:09]:
> >> +
> >> +static int __init pcs_omap_init(void)
> >> +{
> >> +       platform_driver_register(&pcs_omap_soc_driver);
> >> +       platform_driver_register(&pcs_omap_driver);
> >> +
> >> +       return 0;
> >> +}
> >> +module_init(pcs_omap_init);
> >>
> >> It seems this has to be moved to an earlier place (e.g. subsys_initcall)
> >> else the pinctrl core fails to find the pinctrl device at the device creation
> >> time and bails out with -EPROBE_DEFER. Also, that device is never
> >> created again, so -EPROBE_DEFER doesn't seem to work there.
> > 
> > Ah here, found your other comment :)
> > 
> > That's not needed, the real fix is to make twl-core.c and friends to
> > be regular module_init. There are already patches queued for that.
> 
> OK. I was testing with USB host driver and it seems to be loaded as fs_initcall() which
> is the root of the problem. I will fix up the usb host driver to be loaded as module_init()

OK good to hear.

Regards,

Tony

  reply	other threads:[~2013-06-12 13:33 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20130607203936.16513.57494.stgit@localhost>
2013-06-07 20:50 ` [PATCH 1/4] pinctrl: single: Prepare for supporting SoC specific features Tony Lindgren
2013-06-08  9:37   ` Haojian Zhuang
2013-06-08 15:27     ` Tony Lindgren
2013-06-09  5:21       ` Haojian Zhuang
2013-07-22 21:15       ` Linus Walleij
2013-07-29  8:57         ` Tony Lindgren
2013-06-07 20:50 ` [PATCH 2/4] pinctrl: single: Add hardware specific hooks for IRQ and GPIO wake-up events Tony Lindgren
2013-06-09  4:46   ` Haojian Zhuang
2013-06-10 15:36     ` Tony Lindgren
2013-07-22 21:44       ` Linus Walleij
2013-07-29  8:50         ` Tony Lindgren
2013-06-07 20:50 ` [PATCH 3/4] pinctrl: single: omap: Add SoC specific module for " Tony Lindgren
2013-06-08 15:29   ` Tony Lindgren
2013-06-09  5:28   ` Haojian Zhuang
2013-06-10 10:03   ` Quadros, Roger
2013-06-10 15:21     ` Tony Lindgren
2013-06-11 12:51       ` Roger Quadros
2013-06-12 13:33         ` Tony Lindgren [this message]
2013-07-22 22:03   ` Linus Walleij
2013-07-22 22:06   ` Linus Walleij
2013-06-07 20:50 ` [PATCH 4/4] ARM: OMAP: Move DT wake-up event handling over to use pinctrl-single-omap Tony Lindgren
2013-06-07 20:52   ` Tony Lindgren
2013-06-10 15:36     ` Tony Lindgren
2013-06-10 12:31   ` Quadros, Roger
2013-06-10 14:25     ` Tony Lindgren
2013-06-11  9:08       ` Roger Quadros

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130612133306.GR8164@atomide.com \
    --to=tony@atomide.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=haojian.zhuang@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=peter.ujfalusi@ti.com \
    --cc=rogerq@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).