Re: [PATCH 2/2] ARM: dts: add AM33XX MMC support

From: Felipe Balbi <balbi@ti.com>
To: Joel A Fernandes <agnel.joel@gmail.com>
Cc: Chris Ball <cjb@laptop.org>,
	Russell King <linux@arm.linux.org.uk>,
	"Krishnamoorthy, Balaji T" <balajitk@ti.com>,
	Devicetree Discuss <devicetree-discuss@lists.ozlabs.org>,
	Linux MMC List <linux-mmc@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"Hiremath, Vaibhav" <hvaibhav@ti.com>,
	"balbi@ti.com" <balbi@ti.com>,
	Linux OMAP List <linux-omap@vger.kernel.org>,
	Linux ARM Kernel List <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/2] ARM: dts: add AM33XX MMC support
Date: Sat, 15 Jun 2013 18:05:01 +0300	[thread overview]
Message-ID: <20130615150500.GA27629@arwen.pp.htv.fi> (raw)
In-Reply-To: <CAD=GYpYfMAZeV1RUC=DqhYGZaKiiukpTZg7bhO582eKwimS9aA@mail.gmail.com>

[-- Attachment #1.1: Type: text/plain, Size: 1866 bytes --]

Hi,

On Fri, Jun 14, 2013 at 06:43:51PM -0500, Joel A Fernandes wrote:
> > > >> I just doublechecked MMC rootfs on bone and evmsk as it's the standard
> > > >> smoke test. My EVM is intermittent now so trying to coax it to power
> > up
> > > >> to reverify.
> > > >>
> > > >
> > > > Matt,
> > > >
> > > > Your branch is working for me, I tested it on EVM. Not sure what is
> > wrong with manual rebasing
> > > > I did yesterday. I will try to nail-down root-cause here.
> > > >
> > > > And you can submit the next version fixing the comments I have given.
> > >
> > > The only comment I could find in the whole discussion was adding of
> > > the interrupts property. I tested I don't have any problem booting
> > > with Matt's patch, without having the interrupts property.
> >
> > might very well be, but we want to figure out why adding "intrrupts"
> > causes issues. Why does it have to come through hwmod ? You might have
> > uncovered a real problem which needs fixing. Besides, at the end of the
> 
> 
> No actually I think I wasn't very descriptive in my post. There is no
> problem here. Whether it comes from DT or not, it works in both cases . (I
> haven't tried adding interrupt node to dts but what I gathered from
> Vaibhav's post is that it works also when added to dts)
> 
> But I can revisit Vaibhav's suggestion of adding it to dts for completeness
> sake. My tree currently works and picks up the interrupt info from hwmod. I
> just didn't see any activity on this thread for a while so I thought of
> enquiring it was ok to pull it in for the 3.11 merge window or if the
> consensus was that interrupt node be added to dts even though it works
> without it.

fair enough, then let's just add those interrupts to hwmod which will,
eventually, let us drop all of that data from hwmod.

cheers

-- 
balbi

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel