From: "Heiko Stübner" <heiko@sntech.de>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Grant Likely <grant.likely@secretlab.ca>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
James Hogan <james.hogan@imgtec.com>,
"linux-sh@vger.kernel.org" <linux-sh@vger.kernel.org>
Subject: Re: [RFC] pinctrl: generic: Add DT bindings
Date: Sat, 15 Jun 2013 22:16:13 +0200 [thread overview]
Message-ID: <201306152216.14252.heiko@sntech.de> (raw)
In-Reply-To: <CACRpkdaF7V3FGhNNj+N+Dc-NWhsfQ=bqh+ETx0wGBFbLmxfGTw@mail.gmail.com>
Am Samstag, 15. Juni 2013, 21:56:05 schrieb Linus Walleij:
> On Fri, Jun 14, 2013 at 12:39 AM, Laurent Pinchart
>
> <laurent.pinchart@ideasonboard.com> wrote:
> > mmcif_pins: mmcif {
> >
> > mux {
> >
> > renesas,groups = "mmc0_data8_0", "mmc0_ctrl_0";
> > renesas,function = "mmc0";
> >
> > };
> > cfg {
> >
> > renesas,groups = "mmc0_data8_0";
> > renesas,pins = "PORT279";
> > bias-pull-up = <1>;
>
> If I understood your code correctly that last statement can *optionally*
> be written like just:
>
> bias-pull-up;
>
> Without the parameter?
>
> I think that Heiko's implementation does this anyway.
Yep, with the fixes-series from yesterday the bias-pull-* now have a better
default value of <1>.
so you can do
bias-pull-up;
which is then identical to the
bias-pull-up = <1>;
above (both are valid of course).
Disable would the be either
bias-disable;
or
bias-pull-up = <0>;
A driver should probably handle both, as both are valid pinconf options or
this.
next prev parent reply other threads:[~2013-06-15 20:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-11 22:03 [RFC] pinctrl: generic: Add DT bindings Laurent Pinchart
2013-06-12 12:48 ` Grant Likely
2013-06-13 22:39 ` Laurent Pinchart
2013-06-15 19:56 ` Linus Walleij
2013-06-15 20:16 ` Heiko Stübner [this message]
2013-06-15 23:35 ` Laurent Pinchart
2013-06-15 23:51 ` Linus Walleij
2013-06-15 23:52 ` Laurent Pinchart
2013-06-16 0:04 ` Linus Walleij
[not found] ` <201306152216.14252.heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
2013-06-19 21:52 ` Stephen Warren
2013-06-12 14:36 ` James Hogan
2013-06-13 22:46 ` Laurent Pinchart
2013-06-19 21:58 ` Stephen Warren
2013-06-24 9:43 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201306152216.14252.heiko@sntech.de \
--to=heiko@sntech.de \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=james.hogan@imgtec.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).