From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olof Johansson Subject: Re: [PATCH v4 4/4] arm: add basic support for Rockchip RK3066a boards Date: Mon, 17 Jun 2013 14:35:15 -0700 Message-ID: <20130617213515.GK28497@quad.lixom.net> References: <201306131658.36584.heiko@sntech.de> <201306131702.13400.heiko@sntech.de> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: <201306131702.13400.heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Heiko =?iso-8859-1?Q?St=FCbner?= Cc: Mike Turquette , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Rob Herring , Grant Likely , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: devicetree@vger.kernel.org Hi, Just some small comments below. Once fixed: Acked-by: Olof Johansson On Thu, Jun 13, 2013 at 05:02:13PM +0200, Heiko St=FCbner wrote: > + dwmmc@10214000 { > + compatible =3D "rockchip,rk2928-dw-mshc"; does it make sense to fall back and also specify "snps,dw-mshc"? > diff --git a/arch/arm/mach-rockchip/rockchip.c b/arch/arm/mach-rockchip/r= ockchip.c > new file mode 100644 > index 0000000..0933e17 > --- /dev/null > +++ b/arch/arm/mach-rockchip/rockchip.c > @@ -0,0 +1,54 @@ > +/* > + * Device Tree support for Rockchip SoCs > + * > + * Copyright (c) 2013 MundoReader S.L. > + * Author: Heiko Stuebner > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +static void __init rockchip_timer_init(void) > +{ > + of_clk_init(NULL); > + clocksource_of_init(); > +} > + > +static void __init rockchip_dt_init(void) > +{ > +#ifdef CONFIG_CACHE_L2X0 > + l2x0_of_init(0, ~0UL); > +#endif No need to ifdef, there's a stub if CONFIG_CACHE_L2X0 isn't defined. Side comment: I think it would be nice if the generic code did this init if a l2x0 device node was in the device tree, since the only reason to override init_machine is to do this call in addition to of_platform_populate(). > + of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL); > +} > + > +static const char * const rockchip_board_dt_compat[] =3D { > + "rockchip,rk2928", > + "rockchip,rk3066a", > + "rockchip,rk3066b", > + "rockchip,rk3188", > + NULL, > +}; > + > +DT_MACHINE_START(ROCKCHIP_DT, "Rockchip Cortex-A9 (Device Tree)") > + .init_machine =3D rockchip_dt_init, > + .init_time =3D rockchip_timer_init, > + .dt_compat =3D rockchip_board_dt_compat, > +MACHINE_END