From: Arnd Bergmann <arnd@arndb.de>
To: dinguyen@altera.com
Cc: dinh.linux@gmail.com, Pavel Machek <pavel@denx.de>,
devicetree-discuss@lists.ozlabs.org,
Rob Herring <rob.herring@calxeda.com>,
Olof Johansson <olof@lixom.net>,
John Stultz <john.stultz@linaro.org>,
Grant Likely <grant.likely@linaro.org>,
Jamie Iles <jamie@jamieiles.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] ARM: dts: Change dw-apb-timer-osc and dw-apb-timer-sp to just dw-apb-timer
Date: Tue, 18 Jun 2013 15:11:23 +0200 [thread overview]
Message-ID: <201306181511.24004.arnd@arndb.de> (raw)
In-Reply-To: <1371514129-22801-2-git-send-email-dinguyen@altera.com>
On Tuesday 18 June 2013, dinguyen@altera.com wrote:
> @@ -476,27 +476,31 @@
> };
>
> timer0: timer0@ffc08000 {
> - compatible = "snps,dw-apb-timer-sp";
> + compatible = "snps,dw-apb-timer";
> interrupts = <0 167 4>;
> reg = <0xffc08000 0x1000>;
> + clocks = <&osc>;
> };
>
> timer1: timer1@ffc09000 {
> - compatible = "snps,dw-apb-timer-sp";
> + compatible = "snps,dw-apb-timer";
> interrupts = <0 168 4>;
> reg = <0xffc09000 0x1000>;
> + clocks = <&osc>;
> };
I think it would make sense to fix the device name as well, they should
all be named "timer", not "timer0", so I would add
- timer0: timer0@ffc08000 {
+ timer0: timer@ffc08000 {
for all the timers in the dts file here.
Arnd
next prev parent reply other threads:[~2013-06-18 13:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-18 0:08 [PATCH 0/2] Fix potential merge conflict for dw_apb_timer_of dinguyen-EIB2kfCEclfQT0dZR+AlfA
[not found] ` <1371514129-22801-1-git-send-email-dinguyen-EIB2kfCEclfQT0dZR+AlfA@public.gmane.org>
2013-06-18 0:08 ` [PATCH 1/2] ARM: dts: Change dw-apb-timer-osc and dw-apb-timer-sp to just dw-apb-timer dinguyen-EIB2kfCEclfQT0dZR+AlfA
2013-06-18 13:11 ` Arnd Bergmann [this message]
2013-06-18 0:38 ` [PATCH 0/2] Fix potential merge conflict for dw_apb_timer_of John Stultz
2013-06-18 2:11 ` Dinh Nguyen
2013-06-18 15:02 ` Pavel Machek
[not found] ` <20130618150244.GC18055-tWAi6jLit6GreWDznjuHag@public.gmane.org>
2013-06-18 15:38 ` Heiko Stübner
[not found] ` <201306181738.35671.heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
2013-06-18 18:28 ` Heiko Stübner
[not found] ` <201306182028.50762.heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
2013-06-18 18:40 ` John Stultz
[not found] ` <51C0A9AF.4030409-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2013-06-18 20:11 ` Olof Johansson
-- strict thread matches above, loose matches on Subject: below --
2013-07-25 3:43 [PATCH 1/2] ARM: dts: Change dw-apb-timer-osc and dw-apb-timer-sp to just dw-apb-timer dinguyen
2013-07-29 18:25 ` Pavel Machek
2013-08-11 21:45 ` Olof Johansson
2013-08-12 11:57 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201306181511.24004.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dinguyen@altera.com \
--cc=dinh.linux@gmail.com \
--cc=grant.likely@linaro.org \
--cc=jamie@jamieiles.com \
--cc=john.stultz@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=olof@lixom.net \
--cc=pavel@denx.de \
--cc=rob.herring@calxeda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).