Re: [PATCH v2] hwmon: (ina2xx) Add device tree support to pass the shunt resistor

[Guenter Roeck <linux@roeck-us.net>]

On Thu, Jun 20, 2013 at 02:27:18AM +0000, Tang Yuantian-B29983 wrote:
> 
> 
> > -----Original Message-----
> > From: Guenter Roeck [mailto:linux@roeck-us.net]
> > Sent: 2013年6月19日 星期三 23:43
> > To: Tang Yuantian-B29983
> > Cc: khali@linux-fr.org; lm-sensors@lm-sensors.org; devicetree-
> > discuss@lists.ozlabs.org; linux-doc@vger.kernel.org
> > Subject: Re: [PATCH v2] hwmon: (ina2xx) Add device tree support to pass
> > the shunt resistor
> > 
> > On Wed, Jun 19, 2013 at 02:50:20PM +0800, Yuantian.Tang@freescale.com
> > wrote:
> > > From: Tang Yuantian <yuantian.tang@freescale.com>
> > >
> > > Adding another way that is device tree to pass the shunt resistor
> > > value to driver except for platform data.
> > >
> > > Signed-off-by: Tang Yuantian <Yuantian.Tang@freescale.com>
> > 
> > I noticed that of.h include was missing. No need to re-send; I added it
> > myself.
> > Applied to -next.
> > 
> 
> Thanks for your help. Of.h is already included in i2c.h.
> If it is really needed, I should have seen the warning or error when compile.
> Including it explicitly is also a good point.
> 
Common rule is to include a file if its definitions are used. We can not rely
on some other file including it for us, since it is not guaranteed that this
will always be the case.

Thanks,
Guenter