Re: [PATCH 1/6] ARM: mx27: Replace clk_register_clkdev with clock DT lookup

[Markus Pargmann <mpa-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>]

On Thu, Jun 20, 2013 at 12:35:10PM -0300, Fabio Estevam wrote:
> On Thu, Jun 20, 2013 at 12:28 PM, Alexander Shiyan <shc_work-JGs/UdohzUI@public.gmane.org> wrote:
> >> From: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> >>
> >> Similarly as it was done for mx6q, use a DT lookup in order to make maintainance
> >> task for the clock devices easier.
> >>
> >> Signed-off-by: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> >> [Markus Pargmann: Add gpio clocks]
> >> Signed-off-by: Markus Pargmann <mpa-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> >> ---
> >>  arch/arm/boot/dts/imx27.dtsi | 12 ++++++++++++
> >>  1 file changed, 12 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi
> >> index 0695264..48c263c 100644
> >> --- a/arch/arm/boot/dts/imx27.dtsi
> >> +++ b/arch/arm/boot/dts/imx27.dtsi
> >> @@ -208,6 +208,8 @@
> >>                               #gpio-cells = <2>;
> >>                               interrupt-controller;
> >>                               #interrupt-cells = <2>;
> >> +                             clocks = <&clks 47>;
> >> +                             clock-names = "ipg";
> >
> > Clock is not used in the gpio driver, so I doubt the usefulness of this patch.
> 
> I think you meant "this hunk", right?
> 
> My original patch did not have this part. It was added by Markus as
> mentioned in the commit log, and I agree we should go with the
> original version that did not add the gpio clock.

I somehow missed that your patch was applied in march. gpio clocks are
not mentioned in the binding documentation, so I drop this one
completely.

Thanks,

Markus

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |