From: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
To: Bryan Wu <cooloney-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: "devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org"
<devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>,
Richard Purdie <rpurdie-Fm38FmjxZ/leoWH0uzbU5w@public.gmane.org>,
Linux LED Subsystem
<linux-leds-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] leds: Add device tree binding for pca9633
Date: Thu, 27 Jun 2013 00:21:52 -0700 [thread overview]
Message-ID: <20130627072151.GD5523@atomide.com> (raw)
In-Reply-To: <CAK5ve-KapwU9HbrW=VBeKnghhdqSZYKMfsDdGiYcYMwM7LZBNg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
* Bryan Wu <cooloney-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> [130626 16:53]:
> On Wed, Jun 26, 2013 at 7:17 AM, Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> wrote:
> > @@ -22,6 +22,7 @@
> > #include <linux/i2c.h>
> > #include <linux/workqueue.h>
> > #include <linux/slab.h>
> > +#include <linux/of.h>
> > #include <linux/platform_data/leds-pca9633.h>
> >
> > /* LED select registers determine the source that drives LED outputs */
> > @@ -93,6 +94,61 @@ static void pca9633_led_set(struct led_classdev *led_cdev,
> > schedule_work(&pca9633->work);
> > }
> >
> > +#ifdef CONFIG_OF
>
> Shall we use "#if IS_ENABLED(CONFIG_OF)", as Grant pointed out recently.
Thanks will do, I'll also add the push-pull vs totem pole binding
as that can be quite crucial for some hardware configurations.
Regards,
Tony
next prev parent reply other threads:[~2013-06-27 7:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-26 14:17 [PATCH] leds: Add device tree binding for pca9633 Tony Lindgren
[not found] ` <20130626141705.GY5523-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2013-06-26 23:47 ` Bryan Wu
[not found] ` <CAK5ve-KapwU9HbrW=VBeKnghhdqSZYKMfsDdGiYcYMwM7LZBNg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-06-27 7:21 ` Tony Lindgren [this message]
[not found] ` <20130627072151.GD5523-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2013-06-27 14:24 ` Tony Lindgren
[not found] ` <20130627142451.GJ5523-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2013-07-01 19:06 ` Bryan Wu
[not found] ` <CAK5ve-JhW69L86P9m=+bf0+YYo5KCZTthAD-yt4KZ-vsLXLbTg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-07-02 6:06 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130627072151.GD5523@atomide.com \
--to=tony-4v6ys6ai5vpbdgjk7y7tuq@public.gmane.org \
--cc=cooloney-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=linux-leds-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rpurdie-Fm38FmjxZ/leoWH0uzbU5w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).