From: Tony Lindgren <tony@atomide.com>
To: Luciano Coelho <coelho@ti.com>
Cc: Nishanth Menon <nm@ti.com>,
linux-wireless@vger.kernel.org, nsekhar@ti.com,
mturquette@linaro.org, mark.rutland@arm.com, balbi@ti.com,
grant.likely@linaro.org, rob.herring@calxeda.com,
devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 4/9] wl12xx: use frequency instead of enumerations for pdata clocks
Date: Wed, 3 Jul 2013 04:33:34 -0700 [thread overview]
Message-ID: <20130703113334.GY5523@atomide.com> (raw)
In-Reply-To: <1372796850.21065.93.camel@cumari.coelho.fi>
* Luciano Coelho <coelho@ti.com> [130702 13:33]:
> On Tue, 2013-07-02 at 10:02 -0500, Nishanth Menon wrote:
> > On 17:55-20130702, Luciano Coelho wrote:
> > > Instead of defining an enumeration with the FW specific values for the
> > > different clock rates, use the actual frequency instead. Also add a
> > > boolean to specify whether the clock is XTAL or not.
> > >
> > > Change all board files to reflect this.
> > >
> > > Cc: Tony Lindgren <tony@atomide.com>
> > > Cc: Sekhar Nori <nsekhar@ti.com>
> > > Signed-off-by: Luciano Coelho <coelho@ti.com>
> > > ---
> > > arch/arm/mach-davinci/board-da850-evm.c | 3 +-
> > > arch/arm/mach-omap2/board-4430sdp.c | 5 ++-
> > ^^
> > > arch/arm/mach-omap2/board-omap3evm.c | 3 +-
> > > arch/arm/mach-omap2/board-omap4panda.c | 3 +-
> > ^^
> > Please do not add more platform data to platforms that are DT only.
>
> Ah, I hadn't realized that board_omap4panda.c and board-4430sdp.c had
> been removed in linux-next. I base my tree on wireless-next and it
> doesn't contain these changes yet. I would only have noticed this when
> I rebased my tree once the merge window is closed. ;)
>
> Thanks for pointing out, I'll make sure these changes will not be there
> when I send the pull request.
Please separate out the minimal pdata and arch/arm/mach-omap2 changes int
a immutable branch on v3.11-rc1 that I can also pull in. For v3.12, we're
going to be making more boards device tree only, so these changes may
otherwise cause pointless merge conflicts.
Regards,
Tony
next prev parent reply other threads:[~2013-07-03 11:33 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-02 14:55 [PATCH v2 0/9] wilink: add device tree support Luciano Coelho
[not found] ` <1372776948-24840-1-git-send-email-coelho-l0cyMroinI0@public.gmane.org>
2013-07-02 14:55 ` [PATCH v2 1/9] wl1251: split wl251 platform data to a separate structure Luciano Coelho
2013-07-02 14:55 ` [PATCH v2 2/9] wlcore: use irq_flags in pdata instead of hiding it behind a quirk Luciano Coelho
2013-07-02 15:26 ` Felipe Balbi
2013-07-02 20:12 ` Luciano Coelho
2013-07-02 14:55 ` [PATCH v2 4/9] wl12xx: use frequency instead of enumerations for pdata clocks Luciano Coelho
2013-07-02 15:02 ` Nishanth Menon
2013-07-02 20:27 ` Luciano Coelho
2013-07-03 11:33 ` Tony Lindgren [this message]
2013-07-03 12:14 ` Luciano Coelho
[not found] ` <1372776948-24840-5-git-send-email-coelho-l0cyMroinI0@public.gmane.org>
2013-07-02 15:31 ` Felipe Balbi
2013-07-02 20:14 ` Luciano Coelho
2013-07-02 14:55 ` [PATCH v2 6/9] wlcore: add initial device tree support to the sdio module Luciano Coelho
2013-07-02 14:55 ` [PATCH v2 3/9] wlcore: remove pwr_in_suspend from platform data Luciano Coelho
2013-07-02 14:55 ` [PATCH v2 5/9] wlcore: always use one-shot IRQ Luciano Coelho
2013-07-02 15:32 ` Felipe Balbi
2013-07-02 20:16 ` Luciano Coelho
2013-07-02 14:55 ` [PATCH v2 7/9] wlcore: sdio: add wilink clock providers Luciano Coelho
2013-07-02 15:34 ` Felipe Balbi
2013-07-02 21:30 ` Felipe Balbi
2013-07-02 14:55 ` [PATCH v2 8/9] wlcore: sdio: get clocks from device tree Luciano Coelho
[not found] ` <1372776948-24840-9-git-send-email-coelho-l0cyMroinI0@public.gmane.org>
2013-07-02 15:35 ` Felipe Balbi
2013-07-02 20:19 ` Luciano Coelho
2013-07-02 21:32 ` Felipe Balbi
2013-07-02 21:38 ` Luciano Coelho
2013-07-02 14:55 ` [PATCH v2 9/9] wlcore/wl12xx: check if we got correct clock data from DT Luciano Coelho
2013-07-03 10:13 ` [PATCH v2 0/9] wilink: add device tree support Grazvydas Ignotas
2013-07-03 13:45 ` Luciano Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130703113334.GY5523@atomide.com \
--to=tony@atomide.com \
--cc=balbi@ti.com \
--cc=coelho@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@linaro.org \
--cc=nm@ti.com \
--cc=nsekhar@ti.com \
--cc=rob.herring@calxeda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).