From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH 00/10] Orion Watchdog fixes Date: Tue, 16 Jul 2013 09:31:01 +0200 Message-ID: <20130716073101.GB25043@lunn.ch> References: <1373931163-12670-1-git-send-email-ezequiel.garcia@free-electrons.com> <20130716065952.GA25043@lunn.ch> <20130716092059.237ea729@skate> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20130716092059.237ea729@skate> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Thomas Petazzoni Cc: Lior Amsalem , Andrew Lunn , linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Maen Suleiman , wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org, Sebastian Hesselbarth , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Jason Cooper List-Id: devicetree@vger.kernel.org On Tue, Jul 16, 2013 at 09:20:59AM +0200, Thomas Petazzoni wrote: > Dear Andrew Lunn, > > On Tue, 16 Jul 2013 08:59:52 +0200, Andrew Lunn wrote: > > > Maybe i'm missing something here. You are making use of > > orion_timer_ctrl_clrset() from time-orion.c. How will this work on > > 370/XP which has a different clocksource driver? > > I *think* the idea is that the Armada 370/XP driver will expose the > same function, so from the point of view of the watchdog driver, it > will just work. Hi Thomas That was what i was thinking would happen. And then i started to wonder how well the kernel linker deals with multiple definitions of the same symbol. Dove and 370/XP can end up in the same kernel. So we need to have both orion-timer and the 370/XP timer in the same kernel, so we end up with the same symbol in the kernel twice... Lets wait for Ezequiel to answer. Andrew