From: Dan Carpenter <dan.carpenter@oracle.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Mark Brown <broonie@kernel.org>,
Grant Likely <grant.likely@linaro.org>,
devicetree-discuss@lists.ozlabs.org,
kernel-janitors@vger.kernel.org,
Rob Herring <rob.herring@calxeda.com>,
linux-spi@vger.kernel.org
Subject: Re: [patch] spi/xilinx: signedness issue checking platform_get_irq()
Date: Wed, 17 Jul 2013 18:34:26 +0300 [thread overview]
Message-ID: <20130717153426.GD5585@mwanda> (raw)
In-Reply-To: <51E6B259.3030303@wwwdotorg.org>
On Wed, Jul 17, 2013 at 09:03:53AM -0600, Stephen Warren wrote:
> On 07/17/2013 06:26 AM, Dan Carpenter wrote:
> > "xspi->irq" is unsigned int so it's never less than zero. I have added
> > a cast.
>
> Um. Doesn't this just hide a warning, not solve the problem? If the
> value can't be negative, so the if condition never fires, then the cast
> won't change that...
No. It fixes the problem but Mark is right that it's ugly. Sorry
for that. I will resend.
regards,
dan carpenter
next prev parent reply other threads:[~2013-07-17 15:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-17 12:26 [patch] spi/xilinx: signedness issue checking platform_get_irq() Dan Carpenter
2013-07-17 15:03 ` Stephen Warren
2013-07-17 15:34 ` Dan Carpenter [this message]
[not found] ` <20130717122638.GB4851-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org>
2013-07-17 15:05 ` Mark Brown
2013-07-17 15:34 ` [patch v2] " Dan Carpenter
2013-07-17 17:20 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130717153426.GD5585@mwanda \
--to=dan.carpenter@oracle.com \
--cc=broonie@kernel.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@linaro.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).