From: Mark Brown <broonie@kernel.org>
To: Bo Shen <voice.shen@atmel.com>
Cc: alsa-devel@alsa-project.org, devicetree-discuss@lists.ozlabs.org,
nicolas.ferre@atmel.com, linux-sound@vger.kernel.org,
plagnioj@jcrosoft.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ASoC: atmel: add wm8904 based audio machine driver
Date: Fri, 19 Jul 2013 19:06:40 +0100 [thread overview]
Message-ID: <20130719180640.GS9858@sirena.org.uk> (raw)
In-Reply-To: <1374226977-10188-1-git-send-email-voice.shen@atmel.com>
[-- Attachment #1.1: Type: text/plain, Size: 624 bytes --]
On Fri, Jul 19, 2013 at 05:42:57PM +0800, Bo Shen wrote:
> Add wm8904 based audio machine driver for Atmel EK board
Applied, thanks though...
> + mclk = clk_get(NULL, "pck0");
> + if (IS_ERR(mclk)) {
> + dev_err(&pdev->dev, "failed to get pck0\n");
> + ret = PTR_ERR(mclk);
> + goto err_set_audio;
> + }
> +
> + clk_src = clk_get(NULL, "clk32k");
> + if (IS_ERR(clk_src)) {
> + dev_err(&pdev->dev, "failed to get clk32k\n");
> + ret = PTR_ERR(clk_src);
> + goto err_set_audio;
> + }
These should really be devm_clk_get()s and use a device. This can be
revisited after the common clock framework conversion though.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
prev parent reply other threads:[~2013-07-19 18:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-19 9:42 [PATCH] ASoC: atmel: add wm8904 based audio machine driver Bo Shen
2013-07-19 18:06 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130719180640.GS9858@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=plagnioj@jcrosoft.com \
--cc=voice.shen@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).