From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [PATCH] of/irq: Avoid calling list_first_entry() for empty list Date: Sat, 20 Jul 2013 06:35:18 +0100 Message-ID: <20130720053519.41B773E170B@localhost> References: <1371973807.23555.1.camel@phoenix> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1371973807.23555.1.camel@phoenix> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Axel Lin Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Stephen Warren , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring List-Id: devicetree@vger.kernel.org On Sun, 23 Jun 2013 15:50:07 +0800, Axel Lin wrote: > list_first_entry() expects the list is not empty, we need to check if list is > empty before calling list_first_entry(). Thus use list_first_entry_or_null() > instead of list_first_entry(). > > Signed-off-by: Axel Lin Applied, thanks. g. > --- > drivers/of/irq.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/of/irq.c b/drivers/of/irq.c > index a3c1c5a..5c645c7 100644 > --- a/drivers/of/irq.c > +++ b/drivers/of/irq.c > @@ -482,8 +482,9 @@ void __init of_irq_init(const struct of_device_id *matches) > } > > /* Get the next pending parent that might have children */ > - desc = list_first_entry(&intc_parent_list, typeof(*desc), list); > - if (list_empty(&intc_parent_list) || !desc) { > + desc = list_first_entry_or_null(&intc_parent_list, > + typeof(*desc), list); > + if (!desc) { > pr_err("of_irq_init: children remain, but no parents\n"); > break; > } > -- > 1.8.1.2 > > >