From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [PATCH] of/irq: init struct resource to 0 in of_irq_to_resource() Date: Sat, 20 Jul 2013 06:55:05 +0100 Message-ID: <20130720055506.01FE53E16BA@localhost> References: <1374143050-25848-1-git-send-email-bigeasy@linutronix.de> <51E8A937.9030109@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <51E8A937.9030109-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Rob Herring , Sebastian Andrzej Siewior Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Rob Herring List-Id: devicetree@vger.kernel.org On Thu, 18 Jul 2013 21:49:27 -0500, Rob Herring wrote: > On 07/18/2013 05:24 AM, Sebastian Andrzej Siewior wrote: > > It almost does not matter because most users use only the ->start member > > of the struct. However if this struct is passed to a platform device > > which is then added via platform_device_add() then the ->parent member is > > also used. > > Most users don't use the resource struct at all. The ones that do, all > seem to do a memset beforehand. So I think current behavior is correct. > > There are some occurrences that pass a resource in, but then don't > actually use the resource. Those we should fix. It's a reasonable safeguard though. I'm going to apply it. g.