devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Shiyan <shc_work-JGs/UdohzUI@public.gmane.org>
To: Grant Likely <grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
	Bryan Wu <cooloney-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
	linux-leds-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2] of: Add more stubs for non-OF builds
Date: Sat, 20 Jul 2013 16:32:43 +0400	[thread overview]
Message-ID: <20130720163243.5b921a1bd8301ad6eaaeeb05@mail.ru> (raw)
In-Reply-To: <20130720053111.CA86E3E16F4@localhost>

On Sat, 20 Jul 2013 06:31:11 +0100
Grant Likely <grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote:

> On Tue, 18 Jun 2013 18:39:22 +0400, Alexander Shiyan <shc_work-JGs/UdohzUI@public.gmane.org> wrote:
> > Patch adds of_get_next_child and of_get_next_available_child
> > stubs for non-OF builds.
> > 
> > Signed-off-by: Alexander Shiyan <shc_work-JGs/UdohzUI@public.gmane.org>
> > ---
> >  include/linux/of.h | 16 ++++++++++++++--
> >  1 file changed, 14 insertions(+), 2 deletions(-)
> > 
> > diff --git a/include/linux/of.h b/include/linux/of.h
> > index 1fd08ca..c086c1a 100644
> > --- a/include/linux/of.h
> > +++ b/include/linux/of.h
> > @@ -366,8 +366,17 @@ static inline bool of_have_populated_dt(void)
> >  	return false;
> >  }
> >  
> > -#define for_each_child_of_node(parent, child) \
> > -	while (0)
> > +static inline struct device_node *of_get_next_child(
> > +	const struct device_node *node, struct device_node *prev)
> > +{
> > +	return NULL;
> > +}
> > +
> > +static inline struct device_node *of_get_next_available_child(
> > +	const struct device_node *node, struct device_node *prev)
> > +{
> > +	return NULL;
> > +}
> >  
> >  static inline struct device_node *of_get_child_by_name(
> >  					const struct device_node *node,
> > @@ -376,6 +385,9 @@ static inline struct device_node *of_get_child_by_name(
> >  	return NULL;
> >  }
> >  
> > +#define for_each_child_of_node(parent, child) \
> > +	while (0)
> > +
> 
> Why is the for_each_child_of_node() getting moved?

Please forget this patch, this is no longer needed.
A move was to preserve the sort order for "OF" and "non-OF".
Thanks.

-- 
Alexander Shiyan <shc_work-JGs/UdohzUI@public.gmane.org>

      reply	other threads:[~2013-07-20 12:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-18 14:39 [PATCH v2] of: Add more stubs for non-OF builds Alexander Shiyan
     [not found] ` <1371566362-9334-1-git-send-email-shc_work-JGs/UdohzUI@public.gmane.org>
2013-07-20  5:31   ` Grant Likely
2013-07-20 12:32     ` Alexander Shiyan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130720163243.5b921a1bd8301ad6eaaeeb05@mail.ru \
    --to=shc_work-jgs/udohzui@public.gmane.org \
    --cc=cooloney-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    --cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=linux-leds-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).