From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH] ARM: kirkwood: enable S/PDIF Date: Tue, 23 Jul 2013 14:21:04 +0100 Message-ID: <20130723132104.GT24642@n2100.arm.linux.org.uk> References: <20130723102320.56bc4555@armhf> <20130723084347.GP24642@n2100.arm.linux.org.uk> <20130723130622.GB9858@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20130723130622.GB9858@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: Jean-Francois Moine , alsa-devel@alsa-project.org, Takashi Iwai , linux-kernel@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, Liam Girdwood , Rob Herring List-Id: devicetree@vger.kernel.org On Tue, Jul 23, 2013 at 02:06:22PM +0100, Mark Brown wrote: > On Tue, Jul 23, 2013 at 09:43:47AM +0100, Russell King - ARM Linux wrote: > > On Tue, Jul 23, 2013 at 10:23:20AM +0200, Jean-Francois Moine wrote: > > > This patch enables S/PDIF. > > > > Signed-off-by: Jean-Francois Moine > > > I'm not submitting my patch to do this because: > > > (a) we don't know what effect this has on other hardware. > > This patch will do absolutely nothing unless it's used in a machine > driver which connects a S/PDIF CODEC to it. I see no reason not to > apply it, someone with hardware with more complex needs can always build > on it later. So... what if setting this bit causes the SoC to start wiggling a pin with the SPDIF signal which has been used for a different purpose?