From: Robin Gong <b38343@freescale.com>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: broonie@kernel.org, grant.likely@linaro.org,
rob.herring@calxeda.com, rob@landley.net, lgirdwood@gmail.com,
devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, s.trumtrar@pengutronix.de
Subject: Re: [PATCH v5] regulator: pfuze100: add pfuze100 regulator driver
Date: Thu, 25 Jul 2013 16:58:10 +0800 [thread overview]
Message-ID: <20130725085809.GA10765@Robin-OptiPlex-780> (raw)
In-Reply-To: <20130725084042.GA19368@S2101-09.ap.freescale.net>
On Thu, Jul 25, 2013 at 04:40:44PM +0800, Shawn Guo wrote:
> On Thu, Jul 25, 2013 at 11:33:18AM +0800, Robin Gong wrote:
> > @@ -0,0 +1,113 @@
> > +PFUZE100 family of regulators
> > +
> > +Required properties:
> > +- compatible: "fsl,pfuze100"
> > +- reg: I2C slave address
> > +- regulators: This is the list of child nodes that specify the regulator
> > + initialization data for defined regulators. Please refer to below doc
> > + Documentation/devicetree/bindings/regulator/regulator.txt.
>
> I had the comment on v4 patch. The "regulators" should not be
> documented as a property but a sub-node, because it's not a property
> but sub-node.
>
Shawn, I notice there are the same descriptions in the many docs of regulator
drivers, can we consider the 'regulators' child node as one of special property
? Sorry for missing the information in the last mail..
> Shawn
next prev parent reply other threads:[~2013-07-25 8:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-25 3:33 [PATCH v5] regulator: pfuze100: add pfuze100 regulator driver Robin Gong
2013-07-25 8:06 ` Steffen Trumtrar
2013-07-25 8:40 ` Shawn Guo
2013-07-25 8:58 ` Robin Gong [this message]
2013-07-25 9:16 ` Mark Brown
2013-07-25 9:34 ` Robin Gong
2013-07-25 9:32 ` Mark Brown
2013-07-25 10:11 ` Gong Yibin-B38343
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130725085809.GA10765@Robin-OptiPlex-780 \
--to=b38343@freescale.com \
--cc=broonie@kernel.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=s.trumtrar@pengutronix.de \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).