devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Vincent Palatin <vpalatin@chromium.org>
Cc: Grant Likely <grant.likely@linaro.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	linux-kernel@vger.kernel.org, Olof Johansson <olofj@chromium.org>,
	devicetree@vger.kernel.org
Subject: Re: [PATCH] regulator: read low power states configuration from device tree
Date: Thu, 25 Jul 2013 21:03:43 +0100	[thread overview]
Message-ID: <20130725200343.GV9858@sirena.org.uk> (raw)
In-Reply-To: <1374781320-10793-1-git-send-email-vpalatin@chromium.org>

[-- Attachment #1: Type: text/plain, Size: 1203 bytes --]

On Thu, Jul 25, 2013 at 12:42:00PM -0700, Vincent Palatin wrote:

> +- regulator-suspend-disk-microvolt: voltage applied when entering S2D
> +- regulator-suspend-disk-disabled: turn off when entering S2D
> +- regulator-suspend-mem-microvolt: voltage applied when entering S2M
> +- regulator-suspend-mem-disabled: turn off when entering S2M
> +- regulator-suspend-standby-microvolt: voltage applied when entering standby
> +- regulator-suspend-standby-disabled: turn off when entering standby

The reason this isn't in device tree at the minute is that suspend to
disk and suspend to RAM are somewhat Linux specific concepts and the
whole thing gets more and more dynamic as time moves forwards with the
suspend state for practical systems depending on the instantaneous
device state prior to entering suspend and the bits that are fixed often
involving sequencing elements and so on which get fixed in hardware
and/or bootloader.  Do you have practical systems where this is needed?

It's also not clear to me hat the -disabled properties make sense; if we
have properties for the state when enabled I'd expect them to allow
things to be marked as enabled or disabled (with don't touch as the
default).

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2013-07-25 20:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-25 19:42 [PATCH] regulator: read low power states configuration from device tree Vincent Palatin
2013-07-25 20:03 ` Mark Brown [this message]
2013-07-26 16:06   ` Vincent Palatin
2013-07-26 16:23     ` Mark Brown
2013-07-26 20:54   ` Tomasz Figa
2013-07-26 22:42     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130725200343.GV9858@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=grant.likely@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olofj@chromium.org \
    --cc=vpalatin@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).