From: Mark Brown <broonie@kernel.org>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Laxman Dewangan <ldewangan@nvidia.com>,
akpm@linux-foundation.org, grant.likely@linaro.org,
rob.herring@calxeda.com, rob@landley.net,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com,
gg@slimlogic.co.uk, kishon@ti.com,
Stephen Warren <swarren@nvidia.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <Mark.Rutland@arm.com>,
Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH] drivers/rtc/rtc-palmas.c: support for backup battery charging
Date: Fri, 26 Jul 2013 17:35:28 +0100 [thread overview]
Message-ID: <20130726163528.GS9858@sirena.org.uk> (raw)
In-Reply-To: <51F2985F.60202@wwwdotorg.org>
[-- Attachment #1: Type: text/plain, Size: 405 bytes --]
On Fri, Jul 26, 2013 at 09:40:15AM -0600, Stephen Warren wrote:
> Given there's only 1 battery, I think "back-" is redundant in the
> property names. Since that shortens the names a bit, I'd suggest
> spelling everything out in full, perhaps:
Isn't there an integrated charger on the PMIC? If there is then it's
useful to identify which is being talked about (even if it should be
relatively obvious).
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-07-26 16:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-25 12:29 [PATCH] drivers/rtc/rtc-palmas.c: support for backup battery charging Laxman Dewangan
2013-07-26 15:40 ` Stephen Warren
2013-07-26 15:52 ` Mark Rutland
2013-07-26 16:35 ` Mark Brown [this message]
2013-07-26 16:42 ` Stephen Warren
2013-07-27 7:32 ` Laxman Dewangan
2013-07-26 20:45 ` Tomasz Figa
2013-07-27 7:38 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130726163528.GS9858@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Mark.Rutland@arm.com \
--cc=akpm@linux-foundation.org \
--cc=devicetree@vger.kernel.org \
--cc=gg@slimlogic.co.uk \
--cc=grant.likely@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=kishon@ti.com \
--cc=ldewangan@nvidia.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=rtc-linux@googlegroups.com \
--cc=swarren@nvidia.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).