[PATCH] of: add vendor prefix for Altera Corp.

[PATCH] of: add vendor prefix for Altera Corp.

[dinguyen]

From: Dinh Nguyen <dinguyen@altera.com>

Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
Cc: Grant Likely <grant.likely@linaro.org>
Cc: Rob Herring <rob.herring@calxeda.com>
Cc: Pawel Moll <pawel.moll@arm.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Stephen Warren <swarren@wwwdotorg.org>
Cc: Ian Campbell <ian.campbell@citrix.com>
Cc: devicetree@vger.kernel.org
---
 .../devicetree/bindings/vendor-prefixes.txt        |    1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
index 366ce9b..ea95767 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.txt
+++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
@@ -7,6 +7,7 @@ ad	Avionic Design GmbH
 adi	Analog Devices, Inc.
 aeroflexgaisler	Aeroflex Gaisler AB
 ak	Asahi Kasei Corp.
+altr	Altera Corp.
 amcc	Applied Micro Circuits Corporation (APM, formally AMCC)
 apm	Applied Micro Circuits Corporation (APM)
 arm	ARM Ltd.
-- 
1.7.9.5

Re: [PATCH] of: add vendor prefix for Altera Corp.

[Stephen Warren]

On 07/26/2013 01:39 PM, dinguyen@altera.com wrote:

> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt

> +altr	Altera Corp.

In the context of Marvel(?) wanting to change between a longer and
stock-ticker vendor name, there was some discussion re: whether we had
decided not to use stock tickers any more. Is there still consensus that
we should? If so, I have no problem with this patch, but I wanted to
make sure everyone was on the same page.

Re: [PATCH] of: add vendor prefix for Altera Corp.

[Grant Likely]

On Fri, 26 Jul 2013 14:05:26 -0600, Stephen Warren <swarren@wwwdotorg.org> wrote:
> On 07/26/2013 01:39 PM, dinguyen@altera.com wrote:
> 
> > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
> 
> > +altr	Altera Corp.
> 
> In the context of Marvel(?) wanting to change between a longer and
> stock-ticker vendor name, there was some discussion re: whether we had
> decided not to use stock tickers any more. Is there still consensus that
> we should? If so, I have no problem with this patch, but I wanted to
> make sure everyone was on the same page.

Stock ticker names are just fine by me. But once set they should not
change.

g.

Re: [PATCH] of: add vendor prefix for Altera Corp.

[David Gibson]

[-- Attachment #1: Type: text/plain, Size: 1221 bytes --]

On Sat, Jul 27, 2013 at 10:41:25PM -0600, Grant Likely wrote:
> On Fri, 26 Jul 2013 14:05:26 -0600, Stephen Warren <swarren@wwwdotorg.org> wrote:
> > On 07/26/2013 01:39 PM, dinguyen@altera.com wrote:
> > 
> > > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
> > 
> > > +altr	Altera Corp.
> > 
> > In the context of Marvel(?) wanting to change between a longer and
> > stock-ticker vendor name, there was some discussion re: whether we had
> > decided not to use stock tickers any more. Is there still consensus that
> > we should? If so, I have no problem with this patch, but I wanted to
> > make sure everyone was on the same page.
> 
> Stock ticker names are just fine by me. But once set they should not
> change.

The old recommendation from OF working group was that vendor prefixes
could be either ticker symbols in all caps (e.g. "AAPL"), or some
other string in lower case.

We've mostly only used the second option.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: [PATCH] of: add vendor prefix for Altera Corp.

[Mark Rutland]

Dinh,

Apologies for the delay on this.

On Tue, Jul 30, 2013 at 07:10:28AM +0100, David Gibson wrote:
> On Sat, Jul 27, 2013 at 10:41:25PM -0600, Grant Likely wrote:
> > On Fri, 26 Jul 2013 14:05:26 -0600, Stephen Warren <swarren@wwwdotorg.org> wrote:
> > > On 07/26/2013 01:39 PM, dinguyen@altera.com wrote:
> > > 
> > > > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
> > > 
> > > > +altr	Altera Corp.
> > > 
> > > In the context of Marvel(?) wanting to change between a longer and
> > > stock-ticker vendor name, there was some discussion re: whether we had
> > > decided not to use stock tickers any more. Is there still consensus that
> > > we should? If so, I have no problem with this patch, but I wanted to
> > > make sure everyone was on the same page.
> > 
> > Stock ticker names are just fine by me. But once set they should not
> > change.
> 
> The old recommendation from OF working group was that vendor prefixes
> could be either ticker symbols in all caps (e.g. "AAPL"), or some
> other string in lower case.
> 
> We've mostly only used the second option.

Given that all the vendor prefixes we have (even those that are based on 
stock-ticker symbols) are lower case, I'd be happier with the lower-case
"altr" in the original patch.

>From the sounds of it, no-one wants to push for "altera", and we already
have bindings with "altr", so I guess "altr" it is:

Acked-by: Mark Rutland <mark.rutland@arm.com>

I note that there are some bindings with "altr" and some with "ALTR",
though "altr" is more common. It would be nice if the binding documents
were updated mention "ALTR" being deprecated, but useful for
compatibility, hopefully this will lead to less confusion in future.

It would also be nice for the drivers dealing with "ALTR" to be updated
to also support "altr" (without removing support for "ALTR").

Thanks,
Mark.