From: Simon Horman <horms@verge.net.au>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: linux-sh@vger.kernel.org, linux-mmc@vger.kernel.org,
Magnus Damm <magnus.damm@gmail.com>, Chris Ball <cjb@laptop.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH/RFC 2/2] ARM: shmobile: kzm9g: support DDR50 mode with 1.8V VccQ on MMCIF
Date: Tue, 30 Jul 2013 11:18:02 +0900 [thread overview]
Message-ID: <20130730021801.GA31526@verge.net.au> (raw)
In-Reply-To: <Pine.LNX.4.64.1307261748260.22137@axis700.grange>
On Fri, Jul 26, 2013 at 05:51:32PM +0200, Guennadi Liakhovetski wrote:
> MMCIF on sh73a0 supports the UHS DDR50 mode and on the kzm9g board it can
> be used with MMC VccQ = 1.8V. This patch enables them.
>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
> ---
>
> This patch is correct AFAICS, but pointless on kzm9g, because (at least on
> my board) th eMMC chip, installed on the board and connected to MMCIF
> doesn't support DDR, so, it cannot be enabled. This patch is therefore
> more of an example how these flags shall be used, than a real use case. If
> it is decided to apply it, it can be applied even before patch 1/2, it
> just won't have any effect at all.
Thanks, understood.
At this point I prefer not to apply it as it doesn't have any effect.
I am more than happy to discuss this further if others would
like it applied.
>
> arch/arm/boot/dts/sh73a0-kzm9g-reference.dts | 1 +
> arch/arm/boot/dts/sh73a0.dtsi | 1 +
> 2 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts b/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts
> index b99e890..d90de01 100644
> --- a/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts
> +++ b/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts
> @@ -191,6 +191,7 @@
>
> bus-width = <8>;
> vmmc-supply = <®_1p8v>;
> + ddr-1v8;
> status = "okay";
> };
>
> diff --git a/arch/arm/boot/dts/sh73a0.dtsi b/arch/arm/boot/dts/sh73a0.dtsi
> index 86e79fe..1146be8 100644
> --- a/arch/arm/boot/dts/sh73a0.dtsi
> +++ b/arch/arm/boot/dts/sh73a0.dtsi
> @@ -186,6 +186,7 @@
> interrupts = <0 140 0x4
> 0 141 0x4>;
> reg-io-width = <4>;
> + uhs-ddr50;
> status = "disabled";
> };
>
> --
> 1.7.2.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2013-07-30 2:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-26 15:51 [PATCH 1/2] mmc: add Device Tree properties for UHS modes Guennadi Liakhovetski
2013-07-26 15:51 ` [PATCH/RFC 2/2] ARM: shmobile: kzm9g: support DDR50 mode with 1.8V VccQ on MMCIF Guennadi Liakhovetski
2013-07-30 2:18 ` Simon Horman [this message]
2013-07-26 17:10 ` [PATCH 1/2] mmc: add Device Tree properties for UHS modes Stephen Warren
2013-07-26 20:23 ` Guennadi Liakhovetski
2013-07-26 21:36 ` Stephen Warren
2013-07-29 6:20 ` Guennadi Liakhovetski
2013-07-29 7:18 ` Guennadi Liakhovetski
2013-07-29 10:50 ` Pawel Moll
2013-07-29 11:27 ` Guennadi Liakhovetski
2013-07-29 11:42 ` Pawel Moll
2013-07-29 12:05 ` Guennadi Liakhovetski
2013-07-29 13:07 ` Pawel Moll
2013-07-29 13:30 ` Guennadi Liakhovetski
2013-07-29 13:37 ` Pawel Moll
2013-07-29 17:21 ` Stephen Warren
2013-07-29 13:39 ` Rob Herring
2013-07-29 14:40 ` Guennadi Liakhovetski
2013-07-29 17:28 ` Stephen Warren
2013-07-29 10:57 ` Pawel Moll
2013-07-29 11:10 ` Guennadi Liakhovetski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130730021801.GA31526@verge.net.au \
--to=horms@verge.net.au \
--cc=cjb@laptop.org \
--cc=devicetree@vger.kernel.org \
--cc=g.liakhovetski@gmx.de \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).