Re: [PATCH v2 1/4] mtd: nand: gpio: Determine bus width automatically

Olof Johansson
2013-07-30T16:34:36Z

On Tue, Jul 30, 2013 at 03:05:24PM +0400, Alexander Shiyan wrote:
> This patch provide automatically determine of NAND bus width if
> "bank-width" parameter is ommited.
> Patch depends on "mtd: nand: fix NAND_BUSWIDTH_AUTO for x16 devices".
>
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
> .../devicetree/bindings/mtd/gpio-control-nand.txt | 4 ++--
> drivers/mtd/nand/gpio.c | 15 ++++++++++-----
> 2 files changed, 12 insertions(+), 7 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mtd/gpio-control-nand.txt b/Documentation/devicetree/bindings/mtd/gpio-control-nand.txt
> index 36ef07d..2ac14d8 100644
> --- a/Documentation/devicetree/bindings/mtd/gpio-control-nand.txt
> +++ b/Documentation/devicetree/bindings/mtd/gpio-control-nand.txt
> @@ -15,8 +15,8 @@ Required properties:
> optional gpio and may be set to 0 if not present.
>
> Optional properties:
> -- bank-width : Width (in bytes) of the device. If not present, the width
> - defaults to 1 byte.
> +- bank-width : Width (in bytes) of the device. If not present, the bus width
> + of the device is determined automatically.
> - chip-delay : chip dependent delay for transferring data from array to
> read registers (tR). If not present then a default of 20us is used.
> - gpio-control-nand,io-sync-reg : A 64-bit physical address for a read

This would break backwards compatibility, something we're now starting to push
back at.

Instead what you can do is add a bank-width-auto property that, if present and
bank-width being absent, will result in the automatic determination of bank
width.

-Olof