From: Lee Jones <lee.jones@linaro.org>
To: "Kim, Milo" <Milo.Kim@ti.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"Samuel Ortiz (sameo@linux.intel.com)" <sameo@linux.intel.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pwm@vger.kernel.org" <linux-pwm@vger.kernel.org>
Subject: Re: [PATCH v2 4/4] Documentation: dt: bindings: add LP3943 bindings
Date: Wed, 31 Jul 2013 12:09:29 +0100 [thread overview]
Message-ID: <20130731110929.GG13298@lee--X1> (raw)
In-Reply-To: <A874F61F95741C4A9BA573A70FE3998F82E849ED@DQHE06.ent.ti.com>
On Tue, 30 Jul 2013, Kim, Milo wrote:
> Bindings for LP3943 MFD, GPIO and PWM controller are added.
>
> Cc: devicetree@vger.kernel.org
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Samuel Ortiz <sameo@linux.intel.com>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Signed-off-by: Milo Kim <milo.kim@ti.com>
> ---
> .../devicetree/bindings/gpio/gpio-lp3943.txt | 42 +++++++++++++
> Documentation/devicetree/bindings/mfd/lp3943.txt | 33 ++++++++++
> .../devicetree/bindings/pwm/pwm-lp3943.txt | 65 ++++++++++++++++++++
> 3 files changed, 140 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/gpio/gpio-lp3943.txt
> create mode 100644 Documentation/devicetree/bindings/mfd/lp3943.txt
> create mode 100644 Documentation/devicetree/bindings/pwm/pwm-lp3943.txt
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-lp3943.txt b/Documentation/devicetree/bindings/gpio/gpio-lp3943.txt
> new file mode 100644
> index 0000000..952fefd
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpio/gpio-lp3943.txt
> @@ -0,0 +1,42 @@
> +TI/National Semiconductor LP3943 GPIO controller
> +
> +Required properties:
> + - compatible: "ti,lp3943-gpio"
> + - gpio-controller: device node as a GPIO controller
> + - #gpio-cells: Should be two.
> + 1) pin number offset
> + 2) GPIO polarity
> + 0 = active high, 1 = active low
Please use the defines instead on '0' and '1':
include/dt-bindings/gpio/gpio.h
> + gpios = <&gpioex 9 1>; /* active-low */
> + gpios = <&gpioex 10 1>; /* active-low */
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2013-07-31 11:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-30 0:42 [PATCH v2 4/4] Documentation: dt: bindings: add LP3943 bindings Kim, Milo
2013-07-31 11:09 ` Lee Jones [this message]
2013-08-14 10:58 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130731110929.GG13298@lee--X1 \
--to=lee.jones@linaro.org \
--cc=Milo.Kim@ti.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox