From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Jean-Francois Moine <moinejf@free.fr>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.de>,
Rob Herring <rob.herring@calxeda.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3 2/4] ASoc: kirkwood: merge kirkwood-i2c and kirkwood-dma
Date: Sat, 3 Aug 2013 12:46:21 +0100 [thread overview]
Message-ID: <20130803114621.GA19632@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20130803114321.GW23006@n2100.arm.linux.org.uk>
On Sat, Aug 03, 2013 at 12:43:21PM +0100, Russell King - ARM Linux wrote:
> On Wed, Jul 31, 2013 at 08:18:06AM +0200, Jean-Francois Moine wrote:
> > To avoid the declaration of a 'kirkwood-pcm-audio' device in the DT,
> > this patch merges the kirkwood-i2c and kirkwood-dma drivers into one
> > module associated with 'kirkwood-i2s'.
>
> This is broken unless you use my patch. You can't just stick the
> two drivers together because they both make use of the platform
> device's driver data field for two incompatible uses. I've already
> explained that, and I've even sent you a patch to fix that, but you
> seem to ignore anything that you didn't write.
>
> So... I'm going to work on this issue this weekend and merge the two
> drivers myself, and send Mark my own patches to do this.
Sorry, I take that back, your cover email does say that this depends on
my patch. I'll give your patches a go this weekend instead then. Thanks.
next prev parent reply other threads:[~2013-08-03 11:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-31 6:18 [PATCH v3 2/4] ASoc: kirkwood: merge kirkwood-i2c and kirkwood-dma Jean-Francois Moine
2013-08-03 11:43 ` Russell King - ARM Linux
2013-08-03 11:46 ` Russell King - ARM Linux [this message]
2013-08-03 22:23 ` Russell King - ARM Linux
2013-08-04 19:32 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130803114621.GA19632@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=moinejf@free.fr \
--cc=perex@perex.cz \
--cc=rob.herring@calxeda.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).