From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from caramon.arm.linux.org.uk ([78.32.30.218]:40064 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752194Ab3HCNtQ (ORCPT ); Sat, 3 Aug 2013 09:49:16 -0400 Date: Sat, 3 Aug 2013 14:48:55 +0100 From: Russell King - ARM Linux Subject: Re: [PATCH v3 4/4] ASoC: kirkwood: change kirkwood-i2s to mvebu-pcm-audio and DT doc Message-ID: <20130803134855.GZ23006@n2100.arm.linux.org.uk> References: <20130731081858.53413597@armhf> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130731081858.53413597@armhf> Sender: devicetree-owner@vger.kernel.org To: Jean-Francois Moine Cc: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Rob Herring , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org List-ID: On Wed, Jul 31, 2013 at 08:18:58AM +0200, Jean-Francois Moine wrote: > diff --git a/sound/soc/kirkwood/kirkwood-i2s.c b/sound/soc/kirkwood/kirkwood-i2s.c > index 9844010..4f817a2 100644 > --- a/sound/soc/kirkwood/kirkwood-i2s.c > +++ b/sound/soc/kirkwood/kirkwood-i2s.c > @@ -25,7 +25,7 @@ > > #include "kirkwood.h" > > -#define DRV_NAME "kirkwood-i2s" > +#define DRV_NAME "mvebu-pcm-audio" This breaks non-DT users of this driver. The device in arch/arm/mach-kirkwood is left as "kirkwood-i2s" but the platform device is now called something different. > static struct of_device_id kirkwood_i2s_of_match[] = { > - { .compatible = "marvell,kirkwood-i2s" }, > + { .compatible = "marvell,mvebu-pcm-audio" }, You've only just introduced "marvell,kirkwood-i2s" in the previous patch. Why introduce something and then immediately change its name? This makes no sense what so ever.