From: Jean-Francois Moine <moinejf@free.fr>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.de>,
Rob Herring <rob.herring@calxeda.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3 4/4] ASoC: kirkwood: change kirkwood-i2s to mvebu-pcm-audio and DT doc
Date: Sat, 3 Aug 2013 18:26:36 +0200 [thread overview]
Message-ID: <20130803182636.012cccb2@armhf> (raw)
In-Reply-To: <20130803134855.GZ23006@n2100.arm.linux.org.uk>
On Sat, 3 Aug 2013 14:48:55 +0100
Russell King - ARM Linux <linux@arm.linux.org.uk> wrote:
> On Wed, Jul 31, 2013 at 08:18:58AM +0200, Jean-Francois Moine wrote:
> > diff --git a/sound/soc/kirkwood/kirkwood-i2s.c b/sound/soc/kirkwood/kirkwood-i2s.c
> > index 9844010..4f817a2 100644
> > --- a/sound/soc/kirkwood/kirkwood-i2s.c
> > +++ b/sound/soc/kirkwood/kirkwood-i2s.c
> > @@ -25,7 +25,7 @@
> >
> > #include "kirkwood.h"
> >
> > -#define DRV_NAME "kirkwood-i2s"
> > +#define DRV_NAME "mvebu-pcm-audio"
>
> This breaks non-DT users of this driver. The device in arch/arm/mach-kirkwood
> is left as "kirkwood-i2s" but the platform device is now called something
> different.
Oops, sorry, the patch to arch/arm/mach-kirkwood/common.c went away
when I pulled the last kernel.
> > static struct of_device_id kirkwood_i2s_of_match[] = {
> > - { .compatible = "marvell,kirkwood-i2s" },
> > + { .compatible = "marvell,mvebu-pcm-audio" },
>
> You've only just introduced "marvell,kirkwood-i2s" in the previous patch.
> Why introduce something and then immediately change its name? This makes
> no sense what so ever.
2 patches for 2 different purposes. The first one just adds the DT
support. It is enough for DT based kernels. But some people wanted the
device name to be changed to 'mvebu'. So, the second patch.
--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
next prev parent reply other threads:[~2013-08-03 16:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-31 6:18 [PATCH v3 4/4] ASoC: kirkwood: change kirkwood-i2s to mvebu-pcm-audio and DT doc Jean-Francois Moine
2013-08-03 13:48 ` Russell King - ARM Linux
2013-08-03 16:26 ` Jean-Francois Moine [this message]
2013-08-04 19:40 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130803182636.012cccb2@armhf \
--to=moinejf@free.fr \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=perex@perex.cz \
--cc=rob.herring@calxeda.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).